Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: build/android/pylib/flag_changer.py

Issue 11876021: Support startup performance tests on Galaxy S3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/flag_changer.py
diff --git a/build/android/pylib/flag_changer.py b/build/android/pylib/flag_changer.py
index 8b8dbca59055f4a4c7ac1005fd95669ef599dd11..2c5e203b46edd24f604631004ff8bb540e5ddca9 100644
--- a/build/android/pylib/flag_changer.py
+++ b/build/android/pylib/flag_changer.py
@@ -89,11 +89,13 @@ class FlagChanger(object):
print "Current flags: ", self._current_flags
if self._current_flags:
- self._android_cmd.SetFileContents(CHROME_COMMAND_FILE,
- 'chrome ' +
- ' '.join(self._current_flags))
+ # Can't use SetFileContents since that uses push, which doesn't work
+ # on user type builds for protected files.
+ self._android_cmd.RunShellCommand(
bulach 2013/01/14 17:26:50 nit: the escaping makes it hard to read :) how abo
aberent 2013/01/14 20:19:10 It didn't work anyway, once I retested it, so that
+ 'su -c echo \"' + 'chrome ' + ' '.join(self._current_flags) +
+ ' > ' + CHROME_COMMAND_FILE + '\"')
else:
- self._android_cmd.RunShellCommand('rm ' + CHROME_COMMAND_FILE)
+ self._android_cmd.RunShellCommand('su -c rm ' + CHROME_COMMAND_FILE)
def _TokenizeFlags(self, line):
"""Changes the string containing the command line into a list of flags.

Powered by Google App Engine
This is Rietveld 408576698