Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(149)

Issue 11876015: Merge 139416 (Closed)

Created:
7 years, 9 months ago by pfeldman
Modified:
7 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139416 > Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap > https://bugs.webkit.org/show_bug.cgi?id=106555 > > Reviewed by Vsevolod Vlasov. > > Source/WebCore: > > Wrong ::enable was made virtual in the InspectorDebuggerAgent. > > Test: inspector/debugger/debugger-scripts-reload.html > > * inspector/InspectorDebuggerAgent.h: > (InspectorDebuggerAgent): > * inspector/PageDebuggerAgent.cpp: > (WebCore::PageDebuggerAgent::enable): > (WebCore::PageDebuggerAgent::disable): > * inspector/PageDebuggerAgent.h: > (PageDebuggerAgent): > > LayoutTests: > > * http/tests/inspector/debugger-test.js: > (initialize_DebuggerTest): > * inspector/debugger/debugger-scripts-reload-expected.txt: Added. > * inspector/debugger/debugger-scripts-reload.html: Added. TBR=pfeldman@chromium.org BUG=169437 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/inspector/debugger/debugger-scripts-reload.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/InspectorDebuggerAgent.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/PageDebuggerAgent.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/PageDebuggerAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
7 years, 9 months ago (2013-01-14 11:51:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698