Connecting webrtc-internals WebUI frontend with the backend

chrome/browser/media/webrtc_internals.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
-#define CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
+#ifndef CHROME_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
+#define CHROME_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
 
 #include "base/memory/singleton.h"
 #include "base/observer_list.h"
 #include "base/process.h"
 #include "base/values.h"
-#include "content/common/content_export.h"
+#include "content/public/browser/webrtc_internals_interface.h"
 
-struct PeerConnectionInfo;
-
-namespace content {
-
+namespace media {
 class WebRTCInternalsUIObserver;
 
 // This is a singleton class running in the browser process.
 // It collects peer connection infomation from the renderers,
 // forwards the data to WebRTCInternalsUIObserver and
 // sends data collecting commands to the renderers.
-class CONTENT_EXPORT WebRTCInternals {
+class WebRTCInternals : public content::WebRTCInternalsInterface {

[jam, 2013/01/16 19:36:05]

(this is a continution of my previous comment)

the convention is that content declares an interface Foo, chrome's
implementation is ChromeFoo. i.e. see the Content*Client interfaces

[jiayl, 2013/01/17 19:14:11]

Done. WebRTCInternalsInterface --> WebRTCInternals; WebRTCInternals
-->ChromeWebRTCInternals.

  public:
   static WebRTCInternals* GetInstance();
 
   // Methods called when peer connection status changes.

[jam, 2013/01/16 19:36:05]

nit: don't comment methods from parent interface

[jiayl, 2013/01/17 19:14:11]

Done.

-  void AddPeerConnection(base::ProcessId pid, const PeerConnectionInfo& info);
-  void RemovePeerConnection(base::ProcessId pid, int lid);
+  virtual void AddPeerConnection(base::ProcessId pid,
+                                 int lid,
+                                 const std::string& url,
+                                 const std::string& servers,
+                                 const std::string& constraints) OVERRIDE;
+  virtual void RemovePeerConnection(base::ProcessId pid, int lid) OVERRIDE;
 
   // Methods for adding or removing WebRTCInternalsUIObserver.
   void AddObserver(WebRTCInternalsUIObserver *observer);
   void RemoveObserver(WebRTCInternalsUIObserver *observer);
 
  private:
   friend struct DefaultSingletonTraits<WebRTCInternals>;
 
   WebRTCInternals();
   virtual ~WebRTCInternals();
 
   // Send updates to observers on UI thread.
   void SendUpdate(const std::string& command, base::Value* value);
 
   // Only the IO thread should access these fields.
   ObserverList<WebRTCInternalsUIObserver> observers_;
   base::ListValue peer_connection_data_;
 };
 
-}  // namespace content
-
-#endif  // CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
+}  // namespace media
+#endif  // CHROME_BROWSER_MEDIA_WEBRTC_INTERNALS_H_