Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11876002: Make largest_changestamp setter/getter asynchronous. (Closed)

Created:
7 years, 11 months ago by achuithb
Modified:
7 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make largest_changestamp setter/getter asynchronous. BUG=147299 TEST=unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177091

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : clang error #

Patch Set 4 : added unit test #

Total comments: 6

Patch Set 5 : CompareChangestampsAndLoadIfNeeded #

Patch Set 6 : rebase + comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -25 lines) Patch
M chrome/browser/chromeos/drive/drive_feed_loader.h View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_feed_loader.cc View 1 2 3 4 5 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_feed_processor.cc View 1 2 3 4 5 2 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 2 3 4 5 3 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_interface.h View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.h View 1 2 3 4 5 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.cc View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc View 1 2 3 4 5 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/mock_drive_file_system.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 2 3 4 5 3 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
achuithb
This will be stored in the db so needs to be asynchronous. PTAL, Satoru-san.
7 years, 11 months ago (2013-01-11 20:49:35 UTC) #1
achuithb
On 2013/01/11 20:49:35, achuith.bhandarkar wrote: > This will be stored in the db so needs ...
7 years, 11 months ago (2013-01-15 19:04:50 UTC) #2
satorux1
LGTM with nits. https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_feed_loader.h File chrome/browser/chromeos/drive/drive_feed_loader.h (right): https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_feed_loader.h#newcode125 chrome/browser/chromeos/drive/drive_feed_loader.h:125: void CompareChangestamps(const FileOperationCallback& callback, Maybe: CompareChangestampsAndLoadIfNeeded ...
7 years, 11 months ago (2013-01-15 19:19:00 UTC) #3
achuithb
https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc File chrome/browser/chromeos/drive/drive_file_system.cc (right): https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc#newcode158 chrome/browser/chromeos/drive/drive_file_system.cc:158: void OnGetLargestChangestamp(DriveFileSystemMetadata metadata, On 2013/01/15 19:19:01, satorux1 wrote: > ...
7 years, 11 months ago (2013-01-15 22:10:36 UTC) #4
achuithb
https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_feed_loader.h File chrome/browser/chromeos/drive/drive_feed_loader.h (right): https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_feed_loader.h#newcode125 chrome/browser/chromeos/drive/drive_feed_loader.h:125: void CompareChangestamps(const FileOperationCallback& callback, On 2013/01/15 19:19:01, satorux1 wrote: ...
7 years, 11 months ago (2013-01-15 22:19:15 UTC) #5
satorux1
https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc File chrome/browser/chromeos/drive/drive_file_system.cc (right): https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc#newcode158 chrome/browser/chromeos/drive/drive_file_system.cc:158: void OnGetLargestChangestamp(DriveFileSystemMetadata metadata, On 2013/01/15 22:10:36, achuith.bhandarkar wrote: > ...
7 years, 11 months ago (2013-01-16 00:47:30 UTC) #6
achuithb
Thanks for the review! https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc File chrome/browser/chromeos/drive/drive_file_system.cc (right): https://codereview.chromium.org/11876002/diff/13003/chrome/browser/chromeos/drive/drive_file_system.cc#newcode158 chrome/browser/chromeos/drive/drive_file_system.cc:158: void OnGetLargestChangestamp(DriveFileSystemMetadata metadata, On 2013/01/16 ...
7 years, 11 months ago (2013-01-16 01:00:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11876002/29001
7 years, 11 months ago (2013-01-16 01:03:23 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 03:22:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11876002/29001
7 years, 11 months ago (2013-01-16 03:28:59 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 05:31:52 UTC) #11
Message was sent while issue was closed. 
Change committed as 177091

Powered by Google App Engine
This is Rietveld 408576698