Issue 1187583002: Add the ability for Sky content to trigger Android intents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187583002: Add the ability for Sky content to trigger Android intents (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add the ability for Sky content to trigger Android intents We can use these intents to move the demo launcher to the new world. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a54b8ae62da1aa10e851667214c40ba38e9e0a8d

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -17 lines)			Patch
M	sky/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/apk/demo/AndroidManifest.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/apk/demo/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java	View	2 chunks	+9 lines, -0 lines	0 comments	Download
A +	sky/examples/raw/launcher.dart	View	4 chunks	+13 lines, -3 lines	0 comments	Download
A +	sky/services/intents/BUILD.gn	View	1 chunk	+18 lines, -8 lines	0 comments	Download
A +	sky/services/intents/intents.mojom	View	1 chunk	+7 lines, -5 lines	1 comment	Download
A	sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/1187583002/diff/1/sky/services/intents/intents.mojom File sky/services/intents/intents.mojom (right): https://codereview.chromium.org/1187583002/diff/1/sky/services/intents/intents.mojom#newcode7 sky/services/intents/intents.mojom:7: struct Intent { Should this be AndroidIntent?

5 years, 6 months ago (2015-06-12 20:15:19 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-12 20:43:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a54b8ae62da1aa10e851667214c40ba38e9e0a8d (presubmit successful).

Expand Messages | Collapse Messages