Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js

Issue 1187573003: Fix for default value of FetchEvent.cancellable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js b/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
index cacf87bb68eabb2990ed4f06e54da554d67a18cd..00f4f9d40b68f27c52832dcc1254466f64487a66 100644
--- a/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
+++ b/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
@@ -79,16 +79,16 @@ test(function() {
'FetchEvent', 'Type of FetchEvent should be FetchEvent');
assert_equals(
new FetchEvent('FetchEvent').cancelable,
- true, 'Default FetchEvent.cancelable should be true');
+ false, 'Default FetchEvent.cancelable should be false');
assert_equals(
new FetchEvent('FetchEvent').bubbles,
- false, 'Default FetchEvent.bubbles should be true');
+ false, 'Default FetchEvent.bubbles should be false');
jochen (gone - plz use gerrit) 2015/06/17 12:51:31 why did this change? You only touched cancelable.
Paritosh Kumar 2015/06/17 13:15:32 This was typo and corrected in a cl that get rever
assert_equals(
new FetchEvent('FetchEvent').isReload,
false, 'Default FetchEvent.isReload should be false');
assert_equals(
new FetchEvent('FetchEvent', {cancelable: false}).cancelable,
- true, 'FetchEvent.cancelable should be true');
+ false, 'FetchEvent.cancelable should be false');
assert_equals(
new FetchEvent('FetchEvent', {isReload : true}).isReload, true,
'FetchEvent.isReload with option {isReload : true} should be true');
« no previous file with comments | « no previous file | Source/modules/serviceworkers/FetchEvent.cpp » ('j') | Source/modules/serviceworkers/FetchEvent.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698