Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js

Issue 1187573003: Fix for default value of FetchEvent.cancellable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 importScripts('interfaces.js'); 1 importScripts('interfaces.js');
2 importScripts('worker-testharness.js'); 2 importScripts('worker-testharness.js');
3 importScripts('/resources/testharness-helpers.js'); 3 importScripts('/resources/testharness-helpers.js');
4 4
5 var EVENT_HANDLER = 'object'; 5 var EVENT_HANDLER = 'object';
6 6
7 test(function() { 7 test(function() {
8 verify_interface('ServiceWorkerGlobalScope', 8 verify_interface('ServiceWorkerGlobalScope',
9 self, 9 self,
10 { 10 {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 test(function() { 73 test(function() {
74 assert_equals( 74 assert_equals(
75 new ExtendableEvent('ExtendableEvent').type, 75 new ExtendableEvent('ExtendableEvent').type,
76 'ExtendableEvent', 'Type of ExtendableEvent should be ExtendableEvent'); 76 'ExtendableEvent', 'Type of ExtendableEvent should be ExtendableEvent');
77 assert_equals( 77 assert_equals(
78 new FetchEvent('FetchEvent').type, 78 new FetchEvent('FetchEvent').type,
79 'FetchEvent', 'Type of FetchEvent should be FetchEvent'); 79 'FetchEvent', 'Type of FetchEvent should be FetchEvent');
80 assert_equals( 80 assert_equals(
81 new FetchEvent('FetchEvent').cancelable, 81 new FetchEvent('FetchEvent').cancelable,
82 true, 'Default FetchEvent.cancelable should be true'); 82 false, 'Default FetchEvent.cancelable should be false');
83 assert_equals( 83 assert_equals(
84 new FetchEvent('FetchEvent').bubbles, 84 new FetchEvent('FetchEvent').bubbles,
85 false, 'Default FetchEvent.bubbles should be true'); 85 false, 'Default FetchEvent.bubbles should be false');
jochen (gone - plz use gerrit) 2015/06/17 12:51:31 why did this change? You only touched cancelable.
Paritosh Kumar 2015/06/17 13:15:32 This was typo and corrected in a cl that get rever
86 assert_equals( 86 assert_equals(
87 new FetchEvent('FetchEvent').isReload, 87 new FetchEvent('FetchEvent').isReload,
88 false, 'Default FetchEvent.isReload should be false'); 88 false, 'Default FetchEvent.isReload should be false');
89 assert_equals( 89 assert_equals(
90 new FetchEvent('FetchEvent', {cancelable: false}).cancelable, 90 new FetchEvent('FetchEvent', {cancelable: false}).cancelable,
91 true, 'FetchEvent.cancelable should be true'); 91 false, 'FetchEvent.cancelable should be false');
92 assert_equals( 92 assert_equals(
93 new FetchEvent('FetchEvent', {isReload : true}).isReload, true, 93 new FetchEvent('FetchEvent', {isReload : true}).isReload, true,
94 'FetchEvent.isReload with option {isReload : true} should be true'); 94 'FetchEvent.isReload with option {isReload : true} should be true');
95 var req = new Request('http://localhost/', 95 var req = new Request('http://localhost/',
96 {method: 'POST', 96 {method: 'POST',
97 headers: [['Content-Type', 'Text/Html']]}); 97 headers: [['Content-Type', 'Text/Html']]});
98 assert_equals( 98 assert_equals(
99 new FetchEvent('FetchEvent', {request : req, isReload : true}).request.url , 99 new FetchEvent('FetchEvent', {request : req, isReload : true}).request.url ,
100 'http://localhost/', 100 'http://localhost/',
101 'FetchEvent.request.url should return the value it was initialized to'); 101 'FetchEvent.request.url should return the value it was initialized to');
102 }, 'Event constructors'); 102 }, 'Event constructors');
OLDNEW
« no previous file with comments | « no previous file | Source/modules/serviceworkers/FetchEvent.cpp » ('j') | Source/modules/serviceworkers/FetchEvent.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698