Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1187573003: Fix for default value of FetchEvent.cancellable (Closed)

Created:
5 years, 6 months ago by Paritosh Kumar
Modified:
5 years, 6 months ago
CC:
blink-reviews, philipj_slow, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix for default value of FetchEvent.cancellable new FetchEvent('foo').cancellable should be false previously we were setting it to true in FetchEvent::create() method. BUG=501227 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197265

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Paritosh Kumar
Please have a look.
5 years, 6 months ago (2015-06-17 12:33:20 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1187573003/diff/1/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js File LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js (right): https://codereview.chromium.org/1187573003/diff/1/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js#newcode85 LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js:85: false, 'Default FetchEvent.bubbles should be false'); why did this ...
5 years, 6 months ago (2015-06-17 12:51:31 UTC) #4
jochen (gone - plz use gerrit)
also nit for cl description "default" instead of "defulat"
5 years, 6 months ago (2015-06-17 12:52:05 UTC) #5
Paritosh Kumar
Thanks Jochen Updated. Please have a look. https://codereview.chromium.org/1187573003/diff/1/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js File LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js (right): https://codereview.chromium.org/1187573003/diff/1/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js#newcode85 LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js:85: false, 'Default ...
5 years, 6 months ago (2015-06-17 13:15:32 UTC) #6
jochen (gone - plz use gerrit)
ah, I see you changed the string only. lgtm
5 years, 6 months ago (2015-06-17 13:39:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187573003/20001
5 years, 6 months ago (2015-06-17 13:41:25 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:43:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197265

Powered by Google App Engine
This is Rietveld 408576698