Issue 1187563011: Remove deprecated SharedFunctionInfo::dont_cache predicate.

Issue 1187563011: Remove deprecated SharedFunctionInfo::dont_cache predicate. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger

Modified:
5 years, 6 months ago

Reviewers:
rossberg, adamk, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove deprecated SharedFunctionInfo::dont_cache predicate. R=yangguo@chromium.org Committed: https://crrev.com/ad506eebbb0d2f8b1e5833cacba5952af4db10aa Cr-Commit-Position: refs/heads/master@{#29162}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -28 lines)			Patch
M	src/ast.h	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	src/ast-numbering.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/compiler.cc	View	4 chunks	+3 lines, -7 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 10 (2 generated)

Michael Starzinger

Please advise on whether this is intended for some future use which I am not ...

5 years, 6 months ago (2015-06-18 15:04:31 UTC) #1

Yang

LGTM. Apparently this was introduced by https://chromiumcodereview.appspot.com/10690043. So please ask Andreas and Adam whether they ...

5 years, 6 months ago (2015-06-19 06:32:40 UTC) #3

Michael Starzinger

Adam/Andreas: Please advise on whether removal is fine with you.

5 years, 6 months ago (2015-06-19 07:55:04 UTC) #4

rossberg

On 2015/06/19 07:55:04, Michael Starzinger wrote: > Adam/Andreas: Please advise on whether removal is fine ...

5 years, 6 months ago (2015-06-19 07:57:03 UTC) #5

adamk

From my examination of how this was used in the past, it was related to ...

5 years, 6 months ago (2015-06-19 16:08:26 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187563011/1

5 years, 6 months ago (2015-06-19 16:30:13 UTC) #8

commit-bot: I haz the power

5 years, 6 months ago (2015-06-19 18:56:04 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ad506eebbb0d2f8b1e5833cacba5952af4db10aa
Cr-Commit-Position: refs/heads/master@{#29162}