Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: sky/sdk/lib/widgets/scrollable.dart

Issue 1187563006: StockRow height, background color updates (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Correct syncFields super calls Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/fixed_height_scrollable.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/scrollable.dart
diff --git a/sky/sdk/lib/widgets/scrollable.dart b/sky/sdk/lib/widgets/scrollable.dart
index 4cc6a8cf1d68d35c2c65822d7eb0ee4c0adb9e50..1051a4b8b5918fc11f6825a18b6b12b430b21a64 100644
--- a/sky/sdk/lib/widgets/scrollable.dart
+++ b/sky/sdk/lib/widgets/scrollable.dart
@@ -26,9 +26,13 @@ abstract class ScrollClient {
abstract class Scrollable extends Component {
- Scrollable({Object key}) : super(key: key, stateful: true);
+ Scrollable({ Object key, Color this.backgroundColor }) : super(key: key, stateful: true);
- void syncFields(Scrollable source) { }
+ Color backgroundColor;
+
+ void syncFields(Scrollable source) {
+ backgroundColor = source.backgroundColor;
+ }
double _scrollOffset = 0.0;
double get scrollOffset => _scrollOffset;
@@ -49,7 +53,8 @@ abstract class Scrollable extends Component {
return new EventListenerNode(
new Material(
child: buildContent(),
- edge: MaterialEdge.canvas
+ edge: MaterialEdge.canvas,
+ color: backgroundColor
),
onPointerDown: _handlePointerDown,
onPointerUp: _handlePointerUpOrCancel,
« no previous file with comments | « sky/sdk/lib/widgets/fixed_height_scrollable.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698