StockRow height, background color updates

sky/sdk/lib/widgets/scrollable.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:math' as math;
 import 'dart:sky' as sky;
 
 import '../framework/animation/generators.dart';
 import '../framework/animation/mechanics.dart';
 import '../framework/animation/scroll_behavior.dart';
 import '../theme2/edges.dart';
 import '../theme2/view_configuration.dart' as config;
 import 'basic.dart';
 import 'material.dart';
 
 const double _kMillisecondsPerSecond = 1000.0;
 
 double _velocityForFlingGesture(sky.GestureEvent event) {
   return math.max(-config.kMaxFlingVelocity, math.min(config.kMaxFlingVelocity,
       -event.velocityY)) / _kMillisecondsPerSecond;
 }
 
 abstract class ScrollClient {
   bool ancestorScrolled(Scrollable ancestor);
 }
 
 abstract class Scrollable extends Component {
 
-  Scrollable({Object key}) : super(key: key, stateful: true);
+  Scrollable({ Object key, Color this.backgroundColor }) : super(key: key, stateful: true);
 
   void syncFields(Scrollable source) { }

[Hixie, 2015/06/15 17:54:39]

You need to sync the background color.

[hansmuller, 2015/06/15 18:29:08]

Done.

 
+  Color backgroundColor;

[Hixie, 2015/06/15 17:54:39]

This should go immediately below the constructor.

[hansmuller, 2015/06/15 18:29:08]

Done.

+
   double _scrollOffset = 0.0;
   double get scrollOffset => _scrollOffset;
 
   ScrollBehavior _scrollBehavior;
   ScrollBehavior createScrollBehavior();
   ScrollBehavior get scrollBehavior {
     if (_scrollBehavior == null)
       _scrollBehavior = createScrollBehavior();
     return _scrollBehavior;
   }
 
   Simulation _simulation;
 
   UINode buildContent();
 
   UINode build() {
     return new EventListenerNode(
       new Material(
         child: buildContent(),
-        edge: MaterialEdge.canvas
+        edge: MaterialEdge.canvas,
+        color: backgroundColor
       ),
       onPointerDown: _handlePointerDown,
       onPointerUp: _handlePointerUpOrCancel,
       onPointerCancel: _handlePointerUpOrCancel,
       onGestureFlingStart: _handleFlingStart,
       onGestureFlingCancel: _handleFlingCancel,
       onGestureScrollUpdate: _handleScrollUpdate,
       onWheel: _handleWheel
     );
   }
@@ skipping 86 matching lines @@
 
   void _handleFlingCancel(sky.GestureEvent event) {
     _startSimulation(_createParticle());
   }
 
   void _handleWheel(sky.WheelEvent event) {
     scrollBy(-event.offsetY);
   }
 
 }