Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1187543003:
Ship Harmony Array/TypedArray methods (Closed)
|
Created:
5 years, 6 months ago by Dan Ehrenberg Modified:
5 years, 6 months ago Reviewers:
adamk CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionShip Harmony Array/TypedArray methods
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3578
LOG=Y
R=adamk
Committed: https://crrev.com/7142b0d211b732e1c119fded80f43fbbd9cea0f8
Cr-Commit-Position: refs/heads/master@{#29170}
Patch Set 1 #Patch Set 2 : Fix WebKit tests #Patch Set 3 : rebase #Patch Set 4 : increase stack depth #Patch Set 5 : increase stack size to 52 (what?) #Patch Set 6 : stack size 47 again; expect failure of a test on arm64 #
Messages
Total messages: 38 (13 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/1
The author littledan@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/1
The author littledan@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The author littledan@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6872)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by adamk@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/20001
On 2015/06/19 21:16:07, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1187543003/20001 You'll probably have to fix the stack size constant in mjsunit/regress/regress-1132 to avoid ASAN failures
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
On 2015/06/19 21:17:21, caitp wrote: > On 2015/06/19 21:16:07, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1187543003/20001 > > You'll probably have to fix the stack size constant in > mjsunit/regress/regress-1132 to avoid ASAN failures Yup. 47 works for me. Has this yet been reported as a bug anywhere? ASAN failures scare me.
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/1187543003/#ps60001 (title: "increase stack depth")
On 2015/06/19 21:41:11, adamk wrote: > On 2015/06/19 21:17:21, caitp wrote: > > On 2015/06/19 21:16:07, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > https://chromium-cq-status.appspot.com/patch-status/1187543003/20001 > > > > You'll probably have to fix the stack size constant in > > mjsunit/regress/regress-1132 to avoid ASAN failures > > Yup. 47 works for me. Has this yet been reported as a bug anywhere? ASAN > failures scare me. I ran into it trying to ship Object.assign, it will probably happen each time a new experimental script gets flags flipped
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/60001
On 2015/06/19 21:41:11, adamk wrote: > On 2015/06/19 21:17:21, caitp wrote: > > On 2015/06/19 21:16:07, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > https://chromium-cq-status.appspot.com/patch-status/1187543003/20001 > > > > You'll probably have to fix the stack size constant in > > mjsunit/regress/regress-1132 to avoid ASAN failures > > Yup. 47 works for me. Has this yet been reported as a bug anywhere? ASAN > failures scare me. Oh, I see, it's not an ASAN failure, it's a null pointer when running under ASAN.
The new version should expect failure on the remaining test that's failing. It looks to me like bigger than expected space usage, not a real crash
The CQ bit was checked by adamk@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187543003/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/7142b0d211b732e1c119fded80f43fbbd9cea0f8 Cr-Commit-Position: refs/heads/master@{#29170}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1195163002/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Breaks gcstress and mac asan: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/build... http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1774. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
