Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: src/deoptimizer.h

Issue 1187533002: Fix debug printing of inputs in the deoptimizer, pull out printing into separate methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Another tweak Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.h
diff --git a/src/deoptimizer.h b/src/deoptimizer.h
index aa77bf5119c49a53ac571c0ff8b4e9407effa1ae..591505fd459483570740ab1bd501d718942befc4 100644
--- a/src/deoptimizer.h
+++ b/src/deoptimizer.h
@@ -646,9 +646,16 @@ class Deoptimizer : public Malloced {
void DoComputeCompiledStubFrame(TranslationIterator* iterator,
int frame_index);
- void WriteValueToOutput(TranslatedFrame::iterator* iterator, int* input_index,
- int frame_index, unsigned output_offset,
- Address output_address_for_materialization = nullptr);
+ void WriteTranslatedValueToOutput(
+ TranslatedFrame::iterator* iterator, int* input_index, int frame_index,
+ unsigned output_offset, const char* debug_hint_string = nullptr,
+ Address output_address_for_materialization = nullptr);
+ void WriteValueToOutput(Object* value, int input_index, int frame_index,
+ unsigned output_offset,
+ const char* debug_hint_string);
+ void DebugPrintOutputSlot(intptr_t value, int frame_index,
+ unsigned output_offset,
+ const char* debug_hint_string);
unsigned ComputeInputFrameSize() const;
unsigned ComputeFixedSize(JSFunction* function) const;
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698