Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1187503004: Enable slimming paint for virtual/antialiasedtext (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable slimming paint for virtual/antialiasedtext Tests to be rebaselined are because slimming paint force anti-aliasing when drawing borders. BUG=497950 R=chrishtr@chromium.org, wkorman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197079

Patch Set 1 #

Patch Set 2 : TestExpectations #

Total comments: 4

Patch Set 3 : More NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +35 lines, -1 line 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Xianzhu
This is enabled first because we have no easy way (except virtual/slimmingpaint-antialiasedtext) to run these ...
4 years, 10 months ago (2015-06-12 19:31:42 UTC) #2
wkorman
lgtm
4 years, 10 months ago (2015-06-12 19:36:33 UTC) #3
chrishtr
https://codereview.chromium.org/1187503004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1187503004/diff/20001/LayoutTests/TestExpectations#newcode105 LayoutTests/TestExpectations:105: crbug.com/497590 virtual/antialiasedtext/fast/text/atsui-kerning-and-ligatures.html [ NeedsRebaseline ] Do you have sample ...
4 years, 10 months ago (2015-06-12 19:37:22 UTC) #4
Xianzhu
https://codereview.chromium.org/1187503004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1187503004/diff/20001/LayoutTests/TestExpectations#newcode105 LayoutTests/TestExpectations:105: crbug.com/497590 virtual/antialiasedtext/fast/text/atsui-kerning-and-ligatures.html [ NeedsRebaseline ] On 2015/06/12 19:37:22, chrishtr ...
4 years, 10 months ago (2015-06-12 19:39:34 UTC) #5
chrishtr
lgtm
4 years, 10 months ago (2015-06-12 19:42:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187503004/20001
4 years, 10 months ago (2015-06-12 19:42:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187503004/40001
4 years, 10 months ago (2015-06-12 21:11:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66506)
4 years, 10 months ago (2015-06-12 23:46:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187503004/40001
4 years, 10 months ago (2015-06-13 02:26:31 UTC) #15
Xianzhu
4 years, 10 months ago (2015-06-13 02:36:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 197079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698