Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1187503003: Refactor SkyShell to allow multiple SkyViews (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Refactor SkyShell to allow multiple SkyViews This CL separates the view-specific state from the process-global state. The view-specific state now lives on Instance rather than Shell. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/348787ec76e606277a6faf5642b828a7236b4c50

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/instance/sky_shell/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -60 lines) Patch
M sky/shell/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/shell/android/platform_view_android.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M sky/shell/android/platform_view_android.cc View 1 4 chunks +20 lines, -2 lines 0 comments Download
M sky/shell/ios/platform_view_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/shell/ios/sky_surface.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/shell/ios/sky_surface.mm View 1 4 chunks +13 lines, -5 lines 0 comments Download
M sky/shell/ios/sky_view_controller.mm View 1 1 chunk +5 lines, -1 line 0 comments Download
M sky/shell/platform_view.h View 1 chunk +4 lines, -1 line 0 comments Download
M sky/shell/shell.h View 2 chunks +13 lines, -10 lines 0 comments Download
M sky/shell/shell.cc View 3 chunks +8 lines, -33 lines 0 comments Download
A sky/shell/shell_view.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A sky/shell/shell_view.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M sky/shell/ui/engine.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/shell/ui/engine.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-12 18:25:43 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1187503003/diff/1/sky/shell/instance.h File sky/shell/instance.h (right): https://codereview.chromium.org/1187503003/diff/1/sky/shell/instance.h#newcode18 sky/shell/instance.h:18: class Instance { Instance is a pretty generic ...
5 years, 6 months ago (2015-06-12 19:17:35 UTC) #3
abarth-chromium
On 2015/06/12 at 19:17:35, eseidel wrote: > lgtm > > https://codereview.chromium.org/1187503003/diff/1/sky/shell/instance.h > File sky/shell/instance.h (right): ...
5 years, 6 months ago (2015-06-12 20:29:24 UTC) #4
abarth-chromium
5 years, 6 months ago (2015-06-12 20:29:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
348787ec76e606277a6faf5642b828a7236b4c50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698