Constrain native theme menu list arrow to the paint rect

Constrain native theme menu list arrow to the paint rect

If menu lists were drawn very small, the arrow would spill out from the
paint rect. For example, look at the following:
<select style="height:4px; width: 4px"><option>foo</option><option>bar</option></select>
This will draw an arrow entirely outside the select element's bounds.

This patch constrains the menu list arrow so that it does not spill out.
This isn't a problem for other controls because they manually clip or
paint relative to the paint rect. This patch doesn't affect the common
case and should only change edge-case behavior of select elements
smaller than 6px.

TEST=fast/forms/basic-selects.html
BUG=498814
Committed: https://crrev.com/c2acd45a4c5c4b46a717a1872c895538bffd0ee9
Cr-Commit-Position: refs/heads/master@{#334666}

[pdr., 2015-06-12 17:53:32]

pdr@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[pdr., 2015-06-12 17:54:44]

pdr@chromium.org changed reviewers:
- danakj@chromium.org

[enne (OOO), 2015-06-12 17:58:23]

enne@chromium.org changed reviewers:
+ sadrul@chromium.org
- enne@chromium.org

[enne (OOO), 2015-06-12 17:58:35]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2015-06-12 17:58:36]

+sadrul

[pdr., 2015-06-12 19:26:14]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[pdr., 2015-06-12 22:08:55]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-12 22:09:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187503002/20001

[commit-bot: I haz the power, 2015-06-12 23:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 23:08:53]

Dry run: This issue passed the CQ dry run.

[pdr., 2015-06-15 06:55:32]

@sadrul, ping.

[chrishtr, 2015-06-15 21:01:04]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-15 21:01:05]

lgtm

[commit-bot: I haz the power, 2015-06-15 21:02:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187503002/20001

[commit-bot: I haz the power, 2015-06-15 21:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 21:12:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2015-06-15 21:14:19]

On 2015/06/15 at 21:01:05, chrishtr wrote:
> lgtm

Thanks but we still need sadrul's OWNERS superpowerz.

[sadrul, 2015-06-16 14:25:02]

lgtm

[sadrul, 2015-06-16 14:25:52]

one nit:

https://codereview.chromium.org/1187503002/diff/20001/ui/native_theme/native_...
File ui/native_theme/native_theme_base.cc (right):

https://codereview.chromium.org/1187503002/diff/20001/ui/native_theme/native_...
ui/native_theme/native_theme_base.cc:776: static const int arrow_height = 6;
This should be like:

  const int kArrowWidth = 6;
  const int kArrowHeight = 6;

[pdr., 2015-06-16 18:01:44]

On 2015/06/16 at 14:25:52, sadrul wrote:
> one nit:
> 
>
https://codereview.chromium.org/1187503002/diff/20001/ui/native_theme/native_...
> File ui/native_theme/native_theme_base.cc (right):
> 
>
https://codereview.chromium.org/1187503002/diff/20001/ui/native_theme/native_...
> ui/native_theme/native_theme_base.cc:776: static const int arrow_height = 6;
> This should be like:
> 
>   const int kArrowWidth = 6;
>   const int kArrowHeight = 6;

Done. Thanks for the review

[pdr., 2015-06-16 18:01:47]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-06-16 18:01:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1187503002/#ps40001
(title: "Pdr learns a foreign language known as chromium c++ style")

[commit-bot: I haz the power, 2015-06-16 18:02:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187503002/40001

[commit-bot: I haz the power, 2015-06-16 19:53:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-16 19:54:16]

Patchset 3 (id:??) landed as
https://crrev.com/c2acd45a4c5c4b46a717a1872c895538bffd0ee9
Cr-Commit-Position: refs/heads/master@{#334666}