Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 11875012: Merge 138902 (Closed)

Created:
7 years, 9 months ago by kerz_chromium
Modified:
7 years, 9 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138902 > MediaControls::show() should make controls opaque > https://bugs.webkit.org/show_bug.cgi?id=106034 > > Patch by Min Qin <qinmin@chromium.org>; on 2013-01-05 > Reviewed by Eric Carlson. > > Source/WebCore: > > When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires. > If the user exits fullscreen while the timer expires, webkit will call mediaControls::show(). > However, show() actually displays nothing as the control is transparent. > The user had to move his mouse outside the video rect and move it back in order to show the controls. > Simply clicking/moving the mouse inside the video rect will not make the control opaque. > Test: media/video-controls-visible-exiting-fullscreen.html > > * html/shadow/MediaControls.cpp: > (WebCore::MediaControls::show): > > LayoutTests: > > Add tests to check that video controls are shown when exiting from fullscreen. > > * media/video-controls-visible-exiting-fullscreen-expected.txt: Added. > * media/video-controls-visible-exiting-fullscreen.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3472 lines, -4308 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +3473 lines, -0 lines 0 comments Download
A + LayoutTests/media/video-controls-visible-exiting-fullscreen.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/media/video-controls-visible-exiting-fullscreen-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -4310 lines 0 comments Download
M Source/WebCore/html/shadow/MediaControls.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 9 months ago (2013-01-14 00:50:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698