Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1187483004: Simplify WindowProxy handoff in WebFrame::swap(). (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
lfg
CC:
dcheng, blink-reviews, mlamouri+watch-blink_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify WindowProxy handoff in WebFrame::swap(). Calling Frame::detach() later in frame swap allows handoff of the WindowProxy to be simpler, since the handoff no longer has to be done in two separate steps. BUG=371084 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197067

Patch Set 1 #

Patch Set 2 : Slightly reword comment typo #

Patch Set 3 : Moo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M Source/core/frame/Frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/web/WebFrame.cpp View 1 2 4 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Small simplification I thought of. Originally I would help with the "load event firing too ...
4 years, 10 months ago (2015-06-12 20:55:18 UTC) #2
dcheng
4 years, 10 months ago (2015-06-12 20:55:41 UTC) #3
lfg
lgtm
4 years, 10 months ago (2015-06-12 21:45:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187483004/40001
4 years, 10 months ago (2015-06-12 21:49:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 22:57:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197067

Powered by Google App Engine
This is Rietveld 408576698