Issue 1187483003: Fix the expectations file for stocks, since floating action button changed how it was being drawn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187483003: Fix the expectations file for stocks, since floating action button changed how it was being drawn. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fixes tests, logic, and analyzer warnings due to recent checkins. - Fix the expectations file for stocks, since floating action button changed how it was being drawn. - Fix edges theme data to not use a rounded rect path for canvas material. - Add debugging hooks for TextStyle, and fix a warning. TBR=eseidel Committed: https://chromium.googlesource.com/external/mojo/+/bf2d58a4aab50bdd42fb25ce567c0fd33231eef9

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
M	sky/sdk/lib/framework/rendering/paragraph.dart	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/theme2/edges.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/framework/stocks-expected.txt	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Hixie

5 years, 6 months ago (2015-06-12 20:25:40 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bf2d58a4aab50bdd42fb25ce567c0fd33231eef9 (presubmit successful).

Expand Messages | Collapse Messages