Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: sky/sdk/lib/widgets/popup_menu_item.dart

Issue 1187463013: Make PopupMenuItem take a single child instead of an implicitly-flex list of children. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/popup_menu_item.dart
diff --git a/sky/sdk/lib/widgets/popup_menu_item.dart b/sky/sdk/lib/widgets/popup_menu_item.dart
index 9c2e88898093325fdc3b3bb300f156084c400c61..d91e01a9c36e8f8c7e018cf5bea3de349621bbad 100644
--- a/sky/sdk/lib/widgets/popup_menu_item.dart
+++ b/sky/sdk/lib/widgets/popup_menu_item.dart
@@ -6,9 +6,9 @@ import 'basic.dart';
import 'ink_well.dart';
class PopupMenuItem extends Component {
- PopupMenuItem({ String key, this.children, this.opacity}) : super(key: key);
+ PopupMenuItem({ String key, this.child, this.opacity}) : super(key: key);
- final List<UINode> children;
+ final UINode child;
final double opacity;
UINode build() {
@@ -18,7 +18,7 @@ class PopupMenuItem extends Component {
child: new Container(
constraints: const BoxConstraints(minWidth: 112.0),
padding: const EdgeDims.all(16.0),
- child: new Flex(children)
+ child: child
)
)
);
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698