Issue 1187463013: Make PopupMenuItem take a single child instead of an implicitly-flex list of children.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187463013: Make PopupMenuItem take a single child instead of an implicitly-flex list of children. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make PopupMenuItem take a single child instead of an implicitly-flex list of children. TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/8047ab536c17bdaad7d3f6f46521c0166430a481

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	sky/examples/stocks2/lib/stock_menu.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu_item.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

Hixie

5 years, 6 months ago (2015-06-16 16:41:09 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8047ab536c17bdaad7d3f6f46521c0166430a481 (presubmit successful).