Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1187463005: Revert "Remove ambiguity of SkJpegUtility name." (Closed)

Created:
5 years, 6 months ago by scroggo_chromium
Modified:
5 years, 6 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Remove ambiguity of SkJpegUtility name." TBR=mtklein This reverts commit 93858b49a9f3bd3037d61822c095ef59199870af. This revert should fix the Android framework build. NOTREECHECKS=True NOTRY=True Committed: https://skia.googlesource.com/skia/+/27631bd5936e03fcfe854a8aa4e55c8b959a10b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -234 lines) Patch
M gyp/images.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/images/SkJpegUtility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/images/SkJpegUtility.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/images/SkJpegUtility_images.h View 1 chunk +0 lines, -65 lines 0 comments Download
D src/images/SkJpegUtility_images.cpp View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scroggo
lgtm
5 years, 6 months ago (2015-06-15 16:09:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187463005/1
5 years, 6 months ago (2015-06-15 16:09:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/27631bd5936e03fcfe854a8aa4e55c8b959a10b3
5 years, 6 months ago (2015-06-15 16:10:05 UTC) #5
mtklein
Those are public headers?
5 years, 6 months ago (2015-06-15 16:10:22 UTC) #6
scroggo
On 2015/06/15 16:10:22, mtklein wrote: > Those are public headers? No - this is another ...
5 years, 6 months ago (2015-06-15 16:12:34 UTC) #7
mtklein
On 2015/06/15 16:12:34, scroggo wrote: > On 2015/06/15 16:10:22, mtklein wrote: > > Those are ...
5 years, 6 months ago (2015-06-15 16:14:15 UTC) #8
scroggo
5 years, 6 months ago (2015-06-15 16:16:06 UTC) #9
Message was sent while issue was closed.
On 2015/06/15 16:14:15, mtklein wrote:
> On 2015/06/15 16:12:34, scroggo wrote:
> > On 2015/06/15 16:10:22, mtklein wrote:
> > > Those are public headers?
> > 
> > No - this is another case of Android accessing private headers :(
> > 
> > (I mentioned this when I tried to revert using the button, but that failed
due
> > to the A+, and I forgot to mention that in this CL.)
> 
> :(  Can I just rename them the other way around, or are they using
> src/codec/SkJpegUtility.h too?

Haha, no one is using src/codec/SkJpegUtility.h, so renaming the other way
around should be fine.

Powered by Google App Engine
This is Rietveld 408576698