Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4165)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 1187433006: Load language .pak files directly from the apk when using splits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@locale-res-or-file
Patch Set: was totally broken. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 60cf3df98021eb18d8c2eb61a8d3d994f78d50a6..c759ca6ec0952e10bef486fce204cf334af84020 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2227,18 +2227,13 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
&(*regions)[kAndroidChrome100PercentPakDescriptor]);
mappings->Share(kAndroidChrome100PercentPakDescriptor, fd);
- int flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
- const std::string locale = GetApplicationLocale();
- base::FilePath locale_pak = ResourceBundle::GetSharedInstance().
- GetLocaleFilePath(locale, false);
- base::File file(locale_pak, flags);
- DCHECK(file.IsValid());
- mappings->Transfer(kAndroidLocalePakDescriptor,
- base::ScopedFD(file.TakePlatformFile()));
+ fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
+ mappings->Share(kAndroidLocalePakDescriptor, fd);
if (breakpad::IsCrashReporterEnabled()) {
- file = breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id);
+ base::File file =
+ breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
+ child_process_id);
if (file.IsValid()) {
mappings->Transfer(kAndroidMinidumpDescriptor,
base::ScopedFD(file.TakePlatformFile()));

Powered by Google App Engine
This is Rietveld 408576698