Load language .pak files directly from the apk when using splits

Load language .pak files directly from the apk when using splits

Still store them compressed and extract on start-up for when not using
splits, since all locales are included in the apk (would increase size
by ~6megs). When using splits though, only the active language is
shipped to the user, so storing them uncompressed and skipping
extraction makes sense.

This also changes from opening the pak file each time a child process is
spawned to opening it once and caching the handle.

BUG=394502, 490285
Committed: https://crrev.com/4153e51de1c23001defaf19ba58cd15996d1f844
Cr-Commit-Position: refs/heads/master@{#336330}

[agrieve, 2015-06-18 17:58:24]

agrieve@chromium.org changed reviewers:
+ jochen@chromium.org, sadrul@chromium.org, yfriedman@chromium.org

[agrieve, 2015-06-18 17:58:25]

sadrul@chromium.org: Please review changes in ui/

jochen@chromium.org: Please review changes in chrome/

yfriedman@chromium.org: Please review changes in */android/*

[Yaron, 2015-06-18 20:45:44]

https://codereview.chromium.org/1187433006/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main_android.cc (right):

https://codereview.chromium.org/1187433006/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main_android.cc:64: bool has_splits =
base::android::BuildInfo::GetInstance()->has_apk_splits();
how'd you pick here?

https://codereview.chromium.org/1187433006/diff/1/ui/base/resource/resource_b...
File ui/base/resource/resource_bundle_android.h (right):

https://codereview.chromium.org/1187433006/diff/1/ui/base/resource/resource_b...
ui/base/resource/resource_bundle_android.h:32: // Tell ResourceBundle to locate
locale pak files via
nit: update

[agrieve, 2015-06-19 01:37:25]

https://codereview.chromium.org/1187433006/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main_android.cc (right):

https://codereview.chromium.org/1187433006/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main_android.cc:64: bool has_splits =
base::android::BuildInfo::GetInstance()->has_apk_splits();
On 2015/06/18 20:45:43, Yaron wrote:
> how'd you pick here?

This is where webview does it
(android_webview/browser/aw_browser_main_parts.cc). If there's a more
appropriate spot just let me know though.

https://codereview.chromium.org/1187433006/diff/1/ui/base/resource/resource_b...
File ui/base/resource/resource_bundle_android.h (right):

https://codereview.chromium.org/1187433006/diff/1/ui/base/resource/resource_b...
ui/base/resource/resource_bundle_android.h:32: // Tell ResourceBundle to locate
locale pak files via
On 2015/06/18 20:45:43, Yaron wrote:
> nit: update

Done.

[jochen (gone - plz use gerrit), 2015-06-19 13:17:57]

chrome/browser lgtm

[Yaron, 2015-06-19 15:04:42]

lgtm

[agrieve, 2015-06-19 18:09:33]

On 2015/06/19 15:04:42, Yaron wrote:
> lgtm

Turns out this only worked because I had tested with an upgrade rather than a
fresh install (and there were still locale pak files hanging around on the
filesystem).

Change is now much more in line with how the rest of the pak files are handled.

[sadrul, 2015-06-23 08:34:06]

https://codereview.chromium.org/1187433006/diff/40001/ui/base/resource/resour...
File ui/base/resource/resource_bundle_android.h (right):

https://codereview.chromium.org/1187433006/diff/40001/ui/base/resource/resour...
ui/base/resource/resource_bundle_android.h:37: UI_BASE_EXPORT bool
GetLocalePaksStoredInApk();
This doesn't seem to be actually used?

[agrieve, 2015-06-23 15:33:57]

https://codereview.chromium.org/1187433006/diff/40001/ui/base/resource/resour...
File ui/base/resource/resource_bundle_android.h (right):

https://codereview.chromium.org/1187433006/diff/40001/ui/base/resource/resour...
ui/base/resource/resource_bundle_android.h:37: UI_BASE_EXPORT bool
GetLocalePaksStoredInApk();
On 2015/06/23 08:34:06, sadrul wrote:
> This doesn't seem to be actually used?

Good eye. Deleted.

[sadrul, 2015-06-23 15:46:17]

lgtm

[agrieve, 2015-06-25 21:35:01]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-06-25 21:35:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
yfriedman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1187433006/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-25 21:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187433006/80001

[commit-bot: I haz the power, 2015-06-26 00:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 00:00:16]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[agrieve, 2015-06-26 02:06:19]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-06-26 02:06:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
yfriedman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1187433006/#ps100001
(title: "Fix ui_base_unittest failure (allow locale paks to be loaded multiple
times)")

[commit-bot: I haz the power, 2015-06-26 02:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187433006/100001

[commit-bot: I haz the power, 2015-06-26 03:07:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-26 03:08:16]

Patchset 6 (id:??) landed as
https://crrev.com/4153e51de1c23001defaf19ba58cd15996d1f844
Cr-Commit-Position: refs/heads/master@{#336330}