build/android/apks/README.chromium - Issue 1187373002: Add wifi_manager.py and WifiUtils.apk from tradefed to public checkout.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/apks/README.chromium

Issue 1187373002: Add wifi_manager.py and WifiUtils.apk from tradefed to public checkout. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 Name: WifiUtil apk
	perezju 2015/06/18 09:53:33 maybe call this "Android APKs", so in the future w maybe call this "Android APKs", so in the future we can drop here other APKs we might need? jbudorick 2015/06/18 14:21:47 I don't think we want this in build/android/. I th I don't think we want this in build/android/. I think it belongs somewhere in third_party and should only be DEPSed in for android checkouts, similar to how we handle the android SDK in third_party/android_tools. navabi 2015/06/18 16:52:34 So for android_tools we've created and maintain a Show quoted text On 2015/06/18 14:21:47, jbudorick (ooo til 2015-06-18) wrote: > I don't think we want this in build/android/. I think it belongs somewhere in > third_party and should only be DEPSed in for android checkouts, similar to how > we handle the android SDK in third_party/android_tools. So for android_tools we've created and maintain a separate git repo that is then DEPsed. I'm fine putting this in another directory, but I'm reluctant to create a new repo for a single apk. One idea is checking it into the android_tools repo, as it is used as a testing tool on Android. WDYT?
	2 Security Critical: no

	3 Owneres: navabi, jbudorick, perezju

	4

	5 Description:

	6 This directory contains APK used by test devices to connect to wifi.

	7

	8 WifiUtil:

	9 Owner: navabi

	10 Origin: https://source.android.com/devices/tech/test_infra/tradefed/

	11 Version: From the revision bdfc46aa14b33f907f60202604c3667940c5c97a

	12 with cherry-pick e9d4e8bab7fbb696d5f1b8115da35a2ee887bf6c
	perezju 2015/06/18 09:53:33 was this something we built ourselves? we should p was this something we built ourselves? we should probably add how to get this info on the upgrade instructions.
	13 Description:

	14 This is used to enable wifi on a device, connect to a specific network, etc.

	15 WifiUtil is part of Android's open source Trade Federation.

	16 Upgrade instructions:

	17 - Checkout tradefed following these instructions:

	18 https://source.android.com/devices/tech/test_infra/tradefed/fundamentals/

	19 machine_setup.html
	perezju 2015/06/18 09:53:33 To save us a few clicks, maybe also add here the f To save us a few clicks, maybe also add here the full command, e.g.: $ repo init -u https://android.googlesource.com/platform/manifest -b tradefed
	20 - Extract WifiUtil.apk from prebuilt tradefed.jar:

	21 jar xf prebuilts/misc/common/tradefed/tradefed-prebuilt.jar \

	22 apks/wifiutil/WifiUtil.apk

	23 - overwrite WifiUtil.apk with the file extracted from the jar

OLD	NEW

« no previous file with comments | « no previous file | build/android/apks/WifiUtil.apk » ('j') | build/android/pylib/device/wifi_manager.py » ('J')