Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118733002: Added merge session request throttle for XHR requests (Closed)

Created:
7 years ago by zel
Modified:
7 years ago
Reviewers:
xiyuan, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Added merge session request throttle for XHR requests. BUG=308318, 309131, 308681 TEST=manual, added MergeSessionTest.MergeSessionThrottle Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242135

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase\ #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -146 lines) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/merge_session_load_page.h View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/merge_session_load_page.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/merge_session_load_page_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/merge_session_throttle.h View 1 2 3 4 3 chunks +19 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/merge_session_throttle.cc View 1 10 chunks +33 lines, -20 lines 0 comments Download
A chrome/browser/chromeos/login/merge_session_xhr_request_waiter.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/merge_session_xhr_request_waiter.cc View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_browsertest.cc View 1 2 3 4 5 6 12 chunks +290 lines, -91 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_base_test.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_base_test.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/merge_session_load.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/fake_gaia.h View 1 2 3 4 5 6 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
zel
https://codereview.chromium.org/118733002/diff/20001/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right): https://codereview.chromium.org/118733002/diff/20001/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc#newcode109 chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:109: const char kAppLauncherIdPlaceholder[] = "AppLauncherIDPlaceholder-------x"; ignore this....
7 years ago (2013-12-19 00:27:13 UTC) #1
xiyuan
LGTM https://codereview.chromium.org/118733002/diff/30001/chrome/browser/chromeos/login/merge_session_throttle.h File chrome/browser/chromeos/login/merge_session_throttle.h (left): https://codereview.chromium.org/118733002/diff/30001/chrome/browser/chromeos/login/merge_session_throttle.h#oldcode84 chrome/browser/chromeos/login/merge_session_throttle.h:84: DISALLOW_COPY_AND_ASSIGN(MergeSessionThrottle); Does this need to be removed? https://codereview.chromium.org/118733002/diff/30001/chrome/browser/chromeos/login/merge_session_xhr_request_waiter.cc ...
7 years ago (2013-12-19 01:45:41 UTC) #2
zel
+sky for chrome/browser/renderer_host/* https://codereview.chromium.org/118733002/diff/30001/chrome/browser/chromeos/login/merge_session_throttle.h File chrome/browser/chromeos/login/merge_session_throttle.h (left): https://codereview.chromium.org/118733002/diff/30001/chrome/browser/chromeos/login/merge_session_throttle.h#oldcode84 chrome/browser/chromeos/login/merge_session_throttle.h:84: DISALLOW_COPY_AND_ASSIGN(MergeSessionThrottle); On 2013/12/19 01:45:41, xiyuan wrote: ...
7 years ago (2013-12-19 23:28:02 UTC) #3
sky
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc LGTM
7 years ago (2013-12-19 23:31:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/118733002/90001
7 years ago (2013-12-20 00:32:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=64437
7 years ago (2013-12-20 02:02:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/118733002/110001
7 years ago (2013-12-20 03:01:20 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108444
7 years ago (2013-12-20 10:35:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/118733002/110001
7 years ago (2013-12-20 16:43:20 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-20 19:13:40 UTC) #10
Message was sent while issue was closed. 
Change committed as 242135

Powered by Google App Engine
This is Rietveld 408576698