Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1187303002: [DevTools] Added missing EventListenersView addEmptyHolderIfNeeded (Closed)

Created:
5 years, 6 months ago by kozy
Modified:
5 years, 6 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Added missing EventListenersView addEmptyHolderIfNeeded R=lushnikov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/components/EventListenersView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/EventListenersWidget.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kozy
ptal!
5 years, 6 months ago (2015-06-17 15:13:25 UTC) #1
lushnikov
yay, lgtm, thank you!
5 years, 6 months ago (2015-06-17 15:39:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187303002/1
5 years, 6 months ago (2015-06-17 15:44:17 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 19:25:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197271

Powered by Google App Engine
This is Rietveld 408576698