Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1187273005: initialize firstDir (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

initialize firstDir Good catch by Florin; the variable was indeed uninitialized in the complex followed by concave case. R=fmalita@google.com BUG=skia:3953 Committed: https://skia.googlesource.com/skia/+/d83f4955a58cbb9dd523c89ad50e2374a549075e

Patch Set 1 #

Patch Set 2 : rebase first next time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273005/1
5 years, 6 months ago (2015-06-17 15:19:30 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-17 15:19:32 UTC) #3
caryclark
5 years, 6 months ago (2015-06-17 15:19:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/516)
5 years, 6 months ago (2015-06-17 15:20:29 UTC) #7
f(malita)
lgtm
5 years, 6 months ago (2015-06-17 15:29:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273005/20001
5 years, 6 months ago (2015-06-17 15:40:42 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 15:46:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d83f4955a58cbb9dd523c89ad50e2374a549075e

Powered by Google App Engine
This is Rietveld 408576698