Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(71)

Issue 1187273003: Introduce createMarkup function takes two positions (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce createMarkup function takes two positions This patch introduces |createMarkup()| taking two positions by replace calling by template class |CreateMarkupAlgorithm<Strategy>::createMark()| to simplify call sites for improving code health. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197306

Patch Set 1 #

Patch Set 2 : 2015-06-18T09:58:34 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M Source/core/editing/StyledMarkupSerializerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.h View 1 chunk +2 lines, -10 lines 0 comments Download
M Source/core/editing/markup.cpp View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hajimehoshi
lgtm
4 years, 10 months ago (2015-06-17 09:34:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273003/1
4 years, 10 months ago (2015-06-17 09:35:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/11731)
4 years, 10 months ago (2015-06-17 09:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273003/20001
4 years, 10 months ago (2015-06-18 00:59:36 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 02:19:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197306

Powered by Google App Engine
This is Rietveld 408576698