Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1187273002: Skip the whole shadow tree when its tabindex is -1. (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Skip the whole shadow tree when its tabindex is -1. If a shadow host, which has tabindex=-1, is specified as 'delegatesFocus=true' by its shadow root, the whole shadow tree should be skipped for tab navigation order. Design doc: https://docs.google.com/document/d/1k93Ez6yNSyWQDtGjdJJqTBPmljk9l2WS3JTe5OHHB50/edit BUG=496005 TEST=fast/dom/shadow/focus-navigation-with-delegatesFocus.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197251

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M LayoutTests/fast/dom/shadow/focus-navigation-with-delegatesFocus.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/focus-navigation-with-delegatesFocus-expected.txt View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 2 chunks +15 lines, -9 lines 3 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273002/60001
4 years, 10 months ago (2015-06-17 06:47:21 UTC) #4
kochi
PTAL https://codereview.chromium.org/1187273002/diff/60001/Source/core/page/FocusController.cpp File Source/core/page/FocusController.cpp (left): https://codereview.chromium.org/1187273002/diff/60001/Source/core/page/FocusController.cpp#oldcode563 Source/core/page/FocusController.cpp:563: if (!isNonFocusableFocusScopeOwner(*found)) In the previous CL[1], I added ...
4 years, 10 months ago (2015-06-17 07:11:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66975)
4 years, 10 months ago (2015-06-17 09:48:31 UTC) #8
hayato
lgtm
4 years, 10 months ago (2015-06-17 10:18:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187273002/60001
4 years, 10 months ago (2015-06-17 10:26:49 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 11:23:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197251

Powered by Google App Engine
This is Rietveld 408576698