DescriptionRevert of Fix some build symbol configuration. (patchset #2 id:20001 of https://codereview.chromium.org/1182663007/)
Reason for revert:
Broke Linux clobber:
https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1307/steps/compile/logs/stdio
Original issue's description:
> Fix some build symbol configuration.
>
> Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
>
> Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
>
> Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
>
> Reland of https://codereview.chromium.org/1179393004/
>
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/07d847b1c5451748f16f4e7973ce8ef9078d47a2
> Cr-Commit-Position: refs/heads/master@{#334690}
TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/22d6e38d5efdb6a71df80a37094d4b97d7bc060f
Cr-Commit-Position: refs/heads/master@{#334744}
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|