Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: gin/v8_initializer.h

Issue 1187213002: Revert of Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/shell/browser/shell_content_browser_client.cc ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_V8_INITIALIZER_H_ 5 #ifndef GIN_V8_INITIALIZER_H_
6 #define GIN_V8_INITIALIZER_H_ 6 #define GIN_V8_INITIALIZER_H_
7 7
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/files/memory_mapped_file.h"
10 #include "gin/array_buffer.h" 9 #include "gin/array_buffer.h"
11 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
12 #include "gin/public/isolate_holder.h" 11 #include "gin/public/isolate_holder.h"
13 #include "gin/public/v8_platform.h" 12 #include "gin/public/v8_platform.h"
14 #include "v8/include/v8.h" 13 #include "v8/include/v8.h"
15 14
16 namespace gin { 15 namespace gin {
17 16
18 class GIN_EXPORT V8Initializer { 17 class GIN_EXPORT V8Initializer {
19 public: 18 public:
(...skipping 24 matching lines...) Expand all
44 int64 natives_offset, 43 int64 natives_offset,
45 int64 natives_size); 44 int64 natives_size);
46 45
47 // Load V8 snapshot from default resources, if they are available. 46 // Load V8 snapshot from default resources, if they are available.
48 static void LoadV8Snapshot(); 47 static void LoadV8Snapshot();
49 48
50 // Load V8 natives source from default resources. Contains asserts 49 // Load V8 natives source from default resources. Contains asserts
51 // so that it will not return if natives cannot be loaded. 50 // so that it will not return if natives cannot be loaded.
52 static void LoadV8Natives(); 51 static void LoadV8Natives();
53 52
54 // Opens (unless already cached) and returns the V8 natives file. 53 // Opens the V8 snapshot data files and returns open file descriptors to these
55 // Use with LoadV8NativesFromFD(). 54 // files in |natives_fd_out| and |snapshot_fd_out|, which can be passed to
56 // Asserts if the file does not exist. 55 // child processes.
57 static base::PlatformFile GetOpenNativesFileForChildProcesses( 56 static bool OpenV8FilesForChildProcesses(base::PlatformFile* natives_fd_out,
58 base::MemoryMappedFile::Region* region_out); 57 base::PlatformFile* snapshot_fd_out)
59 58 WARN_UNUSED_RESULT;
60 // Opens (unless already cached) and returns the V8 snapshot file.
61 // Use with LoadV8SnapshotFromFD().
62 // Will return -1 if the file does not exist.
63 static base::PlatformFile GetOpenSnapshotFileForChildProcesses(
64 base::MemoryMappedFile::Region* region_out);
65 #endif // V8_USE_EXTERNAL_STARTUP_DATA 59 #endif // V8_USE_EXTERNAL_STARTUP_DATA
66 }; 60 };
67 61
68 } // namespace gin 62 } // namespace gin
69 63
70 #endif // GIN_V8_INITIALIZER_H_ 64 #endif // GIN_V8_INITIALIZER_H_
OLDNEW
« no previous file with comments | « extensions/shell/browser/shell_content_browser_client.cc ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698