Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1187213002: Revert of Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc (Closed)

Created:
5 years, 6 months ago by Marijn Kruisselbrink
Modified:
5 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, extensions-reviews_chromium.org, gunsch+watch_chromium.org, jam, jochen+watch_chromium.org, jshin+watch_chromium.org, kalyank, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, sadrul, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc (patchset #20 id:380001 of https://codereview.chromium.org/1182443003/) Reason for revert: Adds new static initializers in http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=4979 # icu_util.cc cc::VertexShaderQuadAA::VertexShaderQuadAA() # icu_util.cc base::MemoryMappedFile::MemoryMappedFile() # icu_util.cc base::i18n::(anonymous namespace)::g_icudtl_region # icu_util.cc base::i18n::(anonymous namespace)::g_icudtl_mapped_file # icu_util.cc operator new(unsigned long) Original issue's description: > Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc > > Used to be defined in each app's ContentBrowserClient, but since > content/ is the one that receives the FDs, it makes sense that it should > be the one to send them. > > This also removes ChildProcessLauncher::AppendMappedFileCommandLineSwitches > as it is no longer needed. > > BUG=394502 > > Committed: https://crrev.com/228414fc8870f88f11ada7512e88ea6999890f56 > Cr-Commit-Position: refs/heads/master@{#334702} TBR=jochen@chromium.org,jam@chromium.org,jungshik@google.com,michaelbai@chromium.org,rmcilroy@chromium.org,thestig@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=394502 Committed: https://crrev.com/39ae215990f4ff081ca2a505eb2f2adfe22cb4ab Cr-Commit-Position: refs/heads/master@{#334719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -263 lines) Patch
M ash/shell/content_client/shell_content_browser_client.h View 1 chunk +16 lines, -0 lines 0 comments Download
M ash/shell/content_client/shell_content_browser_client.cc View 2 chunks +49 lines, -1 line 0 comments Download
M base/i18n/icu_util.h View 1 chunk +4 lines, -9 lines 0 comments Download
M base/i18n/icu_util.cc View 3 chunks +95 lines, -119 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 6 chunks +58 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 6 chunks +46 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 4 chunks +11 lines, -38 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 4 chunks +40 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_content_browser_client.h View 2 chunks +16 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 4 chunks +46 lines, -1 line 0 comments Download
M gin/v8_initializer.h View 2 chunks +6 lines, -12 lines 0 comments Download
M gin/v8_initializer.cc View 13 chunks +61 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of Moved logic for mapping child process FDs for ICU and V8 into ...
5 years, 6 months ago (2015-06-16 22:26:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187213002/1
5 years, 6 months ago (2015-06-16 22:28:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 22:30:47 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 22:32:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39ae215990f4ff081ca2a505eb2f2adfe22cb4ab
Cr-Commit-Position: refs/heads/master@{#334719}

Powered by Google App Engine
This is Rietveld 408576698