pfeldman@chromium.org changed reviewers: + lushnikov@chromium.org
PTAL
lgtm https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... File LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt:5: content-box rendered dimensions: 75 x 75 why this change? https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... File LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt:191: ['font-family':'serif'] @[0:6-0:25] i don't get this change https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt:210: body.mainpage: [regular, 3:0-3:13] { neither do I get this https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... File Source/core/inspector/InspectorStyleSheet.cpp (left): https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... Source/core/inspector/InspectorStyleSheet.cpp:1776: ASSERT_WITH_SECURITY_IMPLICATION(bodyEnd <= text.length()); // bodyEnd is exclusive move to replace range https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... File Source/core/inspector/InspectorStyleSheet.h (left): https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... Source/core/inspector/InspectorStyleSheet.h:111: mutable std::pair<String, String> m_format; nuke https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... File Source/devtools/front_end/common/TextRange.js (right): https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/common/TextRange.js:275: replaceInText: function(text, replacement) =( https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... File Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1270: remove typecast https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1296: newProperty.setDisabled(false, enabledCallback); you swear you can remove this https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1336: var trimWhitespace = true; insideProperty
https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... File LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt:5: content-box rendered dimensions: 75 x 75 On 2015/06/19 15:34:20, lushnikov wrote: > why this change? Done. https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... File LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/... LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt:191: ['font-family':'serif'] @[0:6-0:25] On 2015/06/19 15:34:20, lushnikov wrote: > i don't get this change Test results of each test depend on the previous. I can either rebaseline it or nuke it :) https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... File Source/core/inspector/InspectorStyleSheet.cpp (left): https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... Source/core/inspector/InspectorStyleSheet.cpp:1776: ASSERT_WITH_SECURITY_IMPLICATION(bodyEnd <= text.length()); // bodyEnd is exclusive Turns out we never hit it any longer. https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... File Source/core/inspector/InspectorStyleSheet.h (left): https://codereview.chromium.org/1187193005/diff/120001/Source/core/inspector/... Source/core/inspector/InspectorStyleSheet.h:111: mutable std::pair<String, String> m_format; On 2015/06/19 15:34:20, lushnikov wrote: > nuke Done. https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... File Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1270: On 2015/06/19 15:34:21, lushnikov wrote: > remove typecast Done. https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1296: newProperty.setDisabled(false, enabledCallback); On 2015/06/19 15:34:21, lushnikov wrote: > you swear you can remove this Done. https://codereview.chromium.org/1187193005/diff/120001/Source/devtools/front_... Source/devtools/front_end/sdk/CSSStyleModel.js:1336: var trimWhitespace = true; On 2015/06/19 15:34:21, lushnikov wrote: > insideProperty Done.
The CQ bit was checked by pfeldman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/1187193005/#ps140001 (title: "for landing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187193005/140001
Committed patchset #8 (id:140001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197489
Chromium Code Reviews
