Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1187193005: DevTools: migrate from CSS.setPropertyText to CSS.setStyleText (Closed)

Created:
5 years, 6 months ago by pfeldman
Modified:
5 years, 6 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: migrate from CSS.setPropertyText to CSS.setStyleText BUG=501311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197489

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : all tests passing #

Total comments: 16

Patch Set 8 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -1734 lines) Patch
D LayoutTests/inspector-protocol/css/css-set-property-text.html View 1 2 1 chunk +0 lines, -189 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-set-property-text-expected.txt View 1 2 1 chunk +0 lines, -234 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-set-property-text-inline.html View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-set-property-text-inline-expected.txt View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-set-style-text.html View 1 2 5 2 chunks +19 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-set-style-text-expected.txt View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/inspector/elements/styles-3/removed-rule-crash.html View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/inspector/elements/styles-3/removed-rule-crash-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M LayoutTests/inspector/elements/styles-3/styles-add-new-rule.html View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles-3/styles-add-new-rule-tab.html View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles-3/styles-disable-inherited.html View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/inspector/elements/styles-4/styles-formatting.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D LayoutTests/inspector/elements/styles-4/styles-formatting-expected.txt View 1 2 3 4 14 chunks +17 lines, -17 lines 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-new-API.html View 1 2 3 chunks +1 line, -215 lines 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt View 1 2 3 chunks +15 lines, -203 lines 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-update-links-expected.txt View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 6 7 3 chunks +5 lines, -96 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 2 3 4 5 6 7 7 chunks +0 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 5 8 chunks +10 lines, -259 lines 0 comments Download
D Source/core/inspector/InspectorStyleTextEditor.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/inspector/InspectorStyleTextEditor.cpp View 1 1 chunk +0 lines, -158 lines 0 comments Download
M Source/devtools/front_end/common/TextRange.js View 1 2 3 chunks +42 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/TextUtils.js View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 2 3 4 5 6 7 3 chunks +139 lines, -59 lines 0 comments Download
M Source/devtools/front_end/ui/DOMSyntaxHighlighter.js View 1 2 3 4 5 6 1 chunk +0 lines, -13 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 5 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
5 years, 6 months ago (2015-06-18 16:36:01 UTC) #2
pfeldman
PTAL
5 years, 6 months ago (2015-06-19 14:53:37 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt File LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt#newcode5 LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt:5: content-box rendered dimensions: 75 x 75 why this ...
5 years, 6 months ago (2015-06-19 15:34:21 UTC) #4
pfeldman
https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt File LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt (right): https://codereview.chromium.org/1187193005/diff/120001/LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt#newcode5 LayoutTests/inspector/elements/styles-2/metrics-box-sizing-expected.txt:5: content-box rendered dimensions: 75 x 75 On 2015/06/19 15:34:20, ...
5 years, 6 months ago (2015-06-19 15:59:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187193005/140001
5 years, 6 months ago (2015-06-19 16:10:05 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 17:41:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197489

Powered by Google App Engine
This is Rietveld 408576698