Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(155)

Issue 1187193002: Enable slimming paint for fast/ (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 : Try bot results without NeedsRebaselines #

Patch Set 2 : #

Patch Set 3 : TestExpectations based on Linux try result #

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -179 lines) Patch
M LayoutTests/LeakExpectations View 3 chunks +0 lines, -13 lines 0 comments Download
M LayoutTests/NeverFixTests View 9 chunks +0 lines, -30 lines 0 comments Download
M LayoutTests/SlowTests View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 6 42 chunks +299 lines, -125 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Xianzhu
virtual/slimmingpaint/fast expectations will be removed in another CL which I won't upload because of its ...
4 years, 10 months ago (2015-06-17 15:38:20 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/1187193002/diff/90001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1187193002/diff/90001/LayoutTests/TestExpectations#newcode381 LayoutTests/TestExpectations:381: crbug.com/497950 fast/backgrounds/background-inherit-color-bug.html [ NeedsRebaseline ] On 2015/06/17 at ...
4 years, 10 months ago (2015-06-17 16:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187193002/90001
4 years, 10 months ago (2015-06-17 16:49:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/35589)
4 years, 10 months ago (2015-06-17 16:56:50 UTC) #7
Xianzhu
We can't land this CL before the android gpu issue is resolved.
4 years, 10 months ago (2015-06-17 16:59:25 UTC) #8
chrishtr
On 2015/06/17 at 16:59:25, wangxianzhu wrote: > We can't land this CL before the android ...
4 years, 10 months ago (2015-06-17 17:01:31 UTC) #9
Xianzhu
4 years, 10 months ago (2015-06-17 17:42:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:110001) manually as 197270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698