Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1187173004: Ship arrow functions (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev, Dmitry Lomov (no reviews), arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship arrow functions R=rossberg@chromium.org LOG=Y BUG=v8:2700 Committed: https://crrev.com/541b6c39e0ecae1c070f51fae8e9e3dab18d278c Cr-Commit-Position: refs/heads/master@{#29119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
wingo
5 years, 6 months ago (2015-06-18 14:21:57 UTC) #1
rossberg
LGTM
5 years, 6 months ago (2015-06-18 14:38:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187173004/1
5 years, 6 months ago (2015-06-18 14:46:17 UTC) #4
commit-bot: I haz the power
The author wingo@igalia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-18 14:46:18 UTC) #5
commit-bot: I haz the power
The author wingo@igalia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-18 15:01:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 15:13:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/541b6c39e0ecae1c070f51fae8e9e3dab18d278c Cr-Commit-Position: refs/heads/master@{#29119}
5 years, 6 months ago (2015-06-18 15:14:01 UTC) #8
Michael Achenbach
5 years, 6 months ago (2015-06-18 19:39:10 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1182053013/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please submit a
needsmanualrebaseline change on the blink side for the expectations if intended.

E.g.
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil....

Powered by Google App Engine
This is Rietveld 408576698