Issue 1187173003: Add the beginnings of a Sky Widgets README.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187173003: Add the beginnings of a Sky Widgets README.md (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add the beginnings of a Sky Widgets README.md There's lots more ground to cover, but this CL is a start. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d8e2eb07543cbe82a8deccece168de8b4f1f17f3

Patch Set 1 #

Patch Set 2 : reupload #

Total comments: 3

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -0 lines)			Patch
	A	sky/sdk/lib/widgets/README.md	View		1 chunk	+223 lines, -0 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I'm going to land this TBR so that Tony can use it this morning.

5 years, 6 months ago (2015-06-17 14:40:11 UTC) #2

abarth-chromium

We can obviously continue to iterate on these docs.

5 years, 6 months ago (2015-06-17 14:40:43 UTC) #3

abarth-chromium

Committed patchset #2 (id:20001) manually as d8e2eb07543cbe82a8deccece168de8b4f1f17f3 (presubmit successful).

5 years, 6 months ago (2015-06-17 14:42:13 UTC) #4

Hixie

5 years, 6 months ago (2015-06-17 16:56:43 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1187173003/diff/20001/sky/sdk/lib/widgets/REA...
File sky/sdk/lib/widgets/README.md (right):

https://codereview.chromium.org/1187173003/diff/20001/sky/sdk/lib/widgets/REA...
sky/sdk/lib/widgets/README.md:15: To build an application, create a subclass of
App and instantiate it:
This example has the unfortunate problem that it'll be black-on-black.

https://codereview.chromium.org/1187173003/diff/20001/sky/sdk/lib/widgets/REA...
sky/sdk/lib/widgets/README.md:72: child: new Flex([
put the child last in the list of arguments. In fact, in general, order the
arguments in the order you talk about them in the next paragraph.

https://codereview.chromium.org/1187173003/diff/20001/sky/sdk/lib/widgets/REA...
sky/sdk/lib/widgets/README.md:117: internally, it expands to fill all the
available horizontal space.
"...so if we didn't do this, it would fill the entire screen."

Expand Messages | Collapse Messages