Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1187153003: Update content module for IPC attachment brokering. (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update content module for IPC attachment brokering. This CL has no functional effect, although it stubs in necessary placeholders for IPC attachment brokering. The browser process now has access to a singleton AttachmentBroker* via content::ChildProcessHost::GetAttachmentBroker(). Child processes now have access to an AttachmentBroker* via content::ChildThread. Each instance of ChildThread creates an AttachmentBroker during Init(). BUG=493414 Committed: https://crrev.com/f7f98882ff232dd35cb03c76b78a8b51bd6643a0 Cr-Commit-Position: refs/heads/master@{#334958}

Patch Set 1 : Trybot run. #

Patch Set 2 : Rebase against in progress CLs. #

Patch Set 3 : Minor comment updates. #

Patch Set 4 : Remove lock. Diff against origin/master. #

Patch Set 5 : Add missing ampersand. (Diff against origin/master). #

Patch Set 6 : Diff against https://codereview.chromium.org/1185133006/. #

Patch Set 7 : Rebase against top of tree. (plugin_service_browsertest was removed) #

Patch Set 8 : Remove confusing parts of comment in ChildProcessHost. #

Patch Set 9 : Use normal inheritance for SupportsAttachmentBrokering rather than virtual inheritance. #

Patch Set 10 : Add virtual inheritance back to ChildThread, since it's involved in a diamond inheritance hierarchy. #

Patch Set 11 : GPUChannelHostFactory also needs to virtually inherit from SupportsAttachmentBrokering. This patch … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -55 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 2 chunks +8 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +19 lines, -4 lines 0 comments Download
M content/child/npapi/np_channel_base.h View 3 chunks +8 lines, -2 lines 0 comments Download
M content/child/npapi/np_channel_base.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 4 chunks +18 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 9 10 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/plugin/plugin_channel.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/plugin/plugin_channel.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/child/child_thread.h View 1 2 9 2 chunks +6 lines, -1 line 0 comments Download
M content/public/common/child_process_host.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/npapi/plugin_channel_host.h View 2 chunks +8 lines, -2 lines 0 comments Download
M content/renderer/npapi/plugin_channel_host.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/1
5 years, 6 months ago (2015-06-16 18:18:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/60001
5 years, 6 months ago (2015-06-16 20:08:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/70001
5 years, 6 months ago (2015-06-16 20:14:46 UTC) #6
erikchen
tsepez: Please review. I will be sending to avi@ afterwards for a content OWNER review.
5 years, 6 months ago (2015-06-16 20:35:37 UTC) #8
Tom Sepez
On 2015/06/16 20:35:37, erikchen wrote: > tsepez: Please review. > > I will be sending ...
5 years, 6 months ago (2015-06-16 21:18:33 UTC) #9
erikchen
avi: Looking for an OWNER review.
5 years, 6 months ago (2015-06-16 21:18:57 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/90001
5 years, 6 months ago (2015-06-16 23:51:14 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/35872) ios_rel_device_ninja on ...
5 years, 6 months ago (2015-06-16 23:56:16 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/110001
5 years, 6 months ago (2015-06-17 00:04:53 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 01:42:05 UTC) #20
Avi (use Gerrit)
I'm a bit lost as to the context here, and given that one of the ...
5 years, 6 months ago (2015-06-17 15:34:58 UTC) #21
Avi (use Gerrit)
As discussed in chat, this was a misunderstanding over a comment. LGTM
5 years, 6 months ago (2015-06-17 20:32:12 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/150001
5 years, 6 months ago (2015-06-17 20:37:30 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/82620) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-17 20:56:43 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/170001
5 years, 6 months ago (2015-06-17 21:14:52 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/99389) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-17 21:34:18 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187153003/190001
5 years, 6 months ago (2015-06-17 21:46:55 UTC) #35
commit-bot: I haz the power
Committed patchset #11 (id:190001)
5 years, 6 months ago (2015-06-17 23:27:16 UTC) #36
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 23:28:57 UTC) #37
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/f7f98882ff232dd35cb03c76b78a8b51bd6643a0
Cr-Commit-Position: refs/heads/master@{#334958}

Powered by Google App Engine
This is Rietveld 408576698