Add a switch for enabling the ManagePasswordsBubbleUI to the about:flags page.

Add a switch for enabling the ManagePasswordsBubbleUI to the about:flags page.

BUG=261628
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242161

[markusheintz_, 2013-12-20 14:22:02]

Please check who to restrict this flag for Win and Chrome OS only

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6787: +        Manage Passwords Bubble UI
Please change to "Enable Passwords bubble"

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6790: +        Enables the Manage Passwords
Bubble UI. The Manage Passwords Bubble UI replaces the infobar for saving
passwords and provides an easy way to manage passwords.
"Enables the Passwords bubble. The Passwords bubble provides an easy way to
store and manage passwords for a website. It replaces the infobar for saving
passwords."

[npentrel, 2013-12-20 14:51:07]

It's restricted to win and aura in about_flags.cc.

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6787: +        Manage Passwords Bubble UI
On 2013/12/20 14:22:02, markusheintz_ wrote:
> Please change to "Enable Passwords bubble"

Done.

https://codereview.chromium.org/118713004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6790: +        Enables the Manage Passwords
Bubble UI. The Manage Passwords Bubble UI replaces the infobar for saving
passwords and provides an easy way to manage passwords.
On 2013/12/20 14:22:02, markusheintz_ wrote:
> "Enables the Passwords bubble. The Passwords bubble provides an easy way to
> store and manage passwords for a website. It replaces the infobar for saving
> passwords."

Done.

[markusheintz_, 2013-12-20 15:35:18]

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1954: #if defined(USE_AURA) || defined(OS_WIN)
don't indent preprocessor directives.

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1962: #endif
Same as above

[npentrel, 2013-12-20 16:03:13]

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1954: #if defined(USE_AURA) || defined(OS_WIN)
On 2013/12/20 15:35:19, markusheintz_ wrote:
> don't indent preprocessor directives.
> 

Done.

https://codereview.chromium.org/118713004/diff/140001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1962: #endif
On 2013/12/20 15:35:19, markusheintz_ wrote:
> Same as above

Done.

[markusheintz_, 2013-12-20 16:04:14]

LGTM

[commit-bot: I haz the power, 2013-12-20 16:07:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/npentrel@chromium.org/118713004/190001

[commit-bot: I haz the power, 2013-12-20 17:07:35]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-20 17:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/npentrel@chromium.org/118713004/450001

[commit-bot: I haz the power, 2013-12-20 20:21:52]

Change committed as 242161