Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: lib/src/runner/browser/content_shell.dart

Issue 1187103004: Allow Suites to be added to an Engine over time. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/runner/browser/content_shell.dart
diff --git a/lib/src/runner/browser/content_shell.dart b/lib/src/runner/browser/content_shell.dart
index 71a5a2506e9bcd7f9252905759d85e80e578c637..917491f63cdf9541c2c7d595017509f39264ac33 100644
--- a/lib/src/runner/browser/content_shell.dart
+++ b/lib/src/runner/browser/content_shell.dart
@@ -8,12 +8,10 @@ import 'dart:async';
import 'dart:convert';
kevmoo 2015/06/17 22:20:04 unused import
nweiz 2015/06/17 22:41:08 Done.
import 'dart:io';
+import '../../utils.dart';
import '../application_exception.dart';
import 'browser.dart';
-/// A converter that transforms a byte stream into a stream of lines.
-final _lines = UTF8.decoder.fuse(const LineSplitter());
-
/// A class for running an instance of the Dartium content shell.
///
/// Most of the communication with the browser is expected to happen via HTTP,
@@ -39,7 +37,7 @@ class ContentShell extends Browser {
executable, ["--dump-render-tree", url.toString()],
environment: {"DART_FLAGS": "--checked"});
- _lines.bind(process.stderr).listen((line) {
+ lineSplitter.bind(process.stderr).listen((line) {
if (line != "[dartToStderr]: Dartium build has expired") return;
// TODO(nweiz): link to dartlang.org once it has download links for

Powered by Google App Engine
This is Rietveld 408576698