Allow Suites to be added to an Engine over time.

test/runner/signal_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Windows doesn't support sending signals.
 @TestOn("vm && !windows")
 
 import 'dart:async';
 import 'dart:convert';

[kevmoo, 2015/06/17 22:20:04]

unused

[nweiz, 2015/06/17 22:41:08]

Done.

 import 'dart:io';
 
 import 'package:path/path.dart' as p;
+import 'package:test/src/util/io.dart';
+import 'package:test/src/utils.dart';
 import 'package:test/test.dart';
-import 'package:test/src/util/io.dart';
 
 import '../io.dart';
 
 String _sandbox;
 
 String get _tempDir => p.join(_sandbox, "tmp");
 
-final _lines = UTF8.decoder.fuse(const LineSplitter());
-
 // This test is inherently prone to race conditions. If it fails, it will likely
 // do so flakily, but if it succeeds, it will succeed consistently. The tests
 // represent a best effort to kill the test runner at certain times during its
 // execution.
 void main() {
   setUp(() {
     _sandbox = createTempDir();
   });
 
   tearDown(() {
     new Directory(_sandbox).deleteSync(recursive: true);
   });
 
   group("during loading,", () {
     test("cleans up if killed while loading a VM test", () async {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
 void main() {
   print("in test.dart");
   // Spin for a long time so the test is probably killed while still loading.
   for (var i = 0; i < 100000000; i++) {}
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).first;
+      var line = await lineSplitter.bind(process.stdout).first;
       expect(line, equals("in test.dart"));
       process.kill();
       await process.exitCode;
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
 
     test("cleans up if killed while loading a browser test", () async {
       new File(p.join(_sandbox, "test.dart"))
           .writeAsStringSync("void main() {}");
 
       var process = await _startTest(["-p", "chrome", "test.dart"]);
-      var line = await _lines.bind(process.stdout).first;
+      var line = await lineSplitter.bind(process.stdout).first;
       expect(line, equals("Compiling test.dart..."));
       process.kill();
       await process.exitCode;
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
 
     test("exits immediately if ^C is sent twice", () async {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
 void main() {
   print("in test.dart");
   while (true) {}
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).first;
+      var line = await lineSplitter.bind(process.stdout).first;
       expect(line, equals("in test.dart"));
       process.kill();
 
       // TODO(nweiz): Sending two signals in close succession can cause the
       // second one to be ignored, so we wait a bit before the second
       // one. Remove this hack when issue 23047 is fixed.
       await new Future.delayed(new Duration(seconds: 1));
       process.kill();
       await process.exitCode;
       expect(new Directory(_tempDir).listSync(), isEmpty);
@@ skipping 12 matching lines @@
   tearDown(() => new File("output").writeAsStringSync("ran teardown"));
 
   test("test", () {
     print("running test");
     return new Future.delayed(new Duration(seconds: 1));
   });
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).skip(2).first;
+      var line = await lineSplitter.bind(process.stdout).skip(2).first;
       expect(line, equals("running test"));
       process.kill();
       await process.exitCode;
       expect(new File(p.join(_sandbox, "output")).readAsStringSync(),
           equals("ran teardown"));
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
 
     test("kills a browser test immediately", () async {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
@@ skipping 11 matching lines @@
       // stops.
       while (true) {}
     });
   });
 }
 """);
 
       var process = await _startTest(["-p", "content-shell", "test.dart"]);
       // The first line is blank, and the second is a status line from the
       // reporter.
-      var line = await _lines.bind(process.stdout).skip(2).first;
+      var line = await lineSplitter.bind(process.stdout).skip(2).first;
       expect(line, equals("running test"));
       process.kill();
       await process.exitCode;
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
 
     test("kills a VM test immediately if ^C is sent twice", () async {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
 import 'package:test/test.dart';
 
 void main() {
   test("test", () {
     print("running test");
     while (true) {}
   });
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).skip(2).first;
+      var line = await lineSplitter.bind(process.stdout).skip(2).first;
       expect(line, equals("running test"));
       process.kill();
 
       // TODO(nweiz): Sending two signals in close succession can cause the
       // second one to be ignored, so we wait a bit before the second
       // one. Remove this hack when issue 23047 is fixed.
       await new Future.delayed(new Duration(seconds: 1));
       process.kill();
       await process.exitCode;
     });
@@ skipping 19 matching lines @@
     try {
       expect(true, isTrue);
     } catch (_) {
       expectThrewError = true;
     }
   });
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).skip(2).first;
+      var line = await lineSplitter.bind(process.stdout).skip(2).first;
       expect(line, equals("running test"));
       process.kill();
       await process.exitCode;
       expect(new File(p.join(_sandbox, "output")).readAsStringSync(),
           equals("true"));
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
 
     test("causes expectAsync() to always throw an error immediately", () async {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
@@ skipping 16 matching lines @@
     try {
       expectAsync(() {});
     } catch (_) {
       expectAsyncThrewError = true;
     }
   });
 }
 """);
 
       var process = await _startTest(["test.dart"]);
-      var line = await _lines.bind(process.stdout).skip(2).first;
+      var line = await lineSplitter.bind(process.stdout).skip(2).first;
       expect(line, equals("running test"));
       process.kill();
       await process.exitCode;
       expect(new File(p.join(_sandbox, "output")).readAsStringSync(),
           equals("true"));
       expect(new Directory(_tempDir).listSync(), isEmpty);
     });
   });
 }
 
 Future<Process> _startTest(List<String> args) {
   new Directory(_tempDir).create();
   return startTest(args, workingDirectory: _sandbox,
       environment: {"_UNITTEST_TEMP_DIR": _tempDir});
 }