Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1187073016: DevTools: generalize getPlatformFonts code (Closed)

Created:
5 years, 6 months ago by lushnikov
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: generalize getPlatformFonts code This patch generalizes getPLatformFonts code to rely on LayoutObjects alltogether. This makes it work for <select> element. BUG=500910 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197465

Patch Set 1 #

Total comments: 2

Patch Set 2 : do not dump cssFamilyFontName #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -65 lines) Patch
M LayoutTests/inspector-protocol/css/css-get-platform-fonts.html View 1 3 chunks +39 lines, -25 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-get-platform-fonts-expected.txt View 1 1 chunk +9 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 chunks +15 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lushnikov
ptal
5 years, 6 months ago (2015-06-17 20:39:35 UTC) #1
pfeldman
https://codereview.chromium.org/1187073016/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1187073016/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode858 Source/core/inspector/InspectorCSSAgent.cpp:858: // Iterate upto two layers deep. Why not N ...
5 years, 6 months ago (2015-06-18 06:48:09 UTC) #2
lushnikov
https://codereview.chromium.org/1187073016/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1187073016/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode858 Source/core/inspector/InspectorCSSAgent.cpp:858: // Iterate upto two layers deep. On 2015/06/18 06:48:09, ...
5 years, 6 months ago (2015-06-18 10:29:14 UTC) #3
pfeldman
lgtm
5 years, 6 months ago (2015-06-18 10:38:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187073016/1
5 years, 6 months ago (2015-06-18 13:37:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59512)
5 years, 6 months ago (2015-06-18 15:19:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187073016/20001
5 years, 6 months ago (2015-06-19 10:58:06 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 12:06:49 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197465

Powered by Google App Engine
This is Rietveld 408576698