Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 1187073014: Templatize PositionWithAffinity class (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent, tasak
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize PositionWithAffinity class Now |PositionWithAffinity| works only on DOM tree. This patch templatizes |PositionWithAffinity| class and end enables it to allow other node-traversing strategies, such as composed tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197247

Patch Set 1 : 2015-06-17T16:08:11 #

Patch Set 2 : 2015-06-17T16:31:27 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -19 lines) Patch
M Source/core/editing/Caret.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/PositionWithAffinity.h View 1 1 chunk +17 lines, -7 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.cpp View 1 chunk +7 lines, -7 lines 1 comment Download
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-17 08:02:37 UTC) #1
yosin_UTC9
4 years, 10 months ago (2015-06-17 08:02:51 UTC) #3
tkent
lgtm
4 years, 10 months ago (2015-06-17 08:15:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187073014/20001
4 years, 10 months ago (2015-06-17 08:16:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197247
4 years, 10 months ago (2015-06-17 09:39:53 UTC) #7
tasak
4 years, 10 months ago (2015-06-29 08:11:02 UTC) #9
Message was sent while issue was closed.
CORE_EXTERN_TEMPLATE in cpp will cause Android_compile_dbg compile failure when
using component build.

I will fix.

https://codereview.chromium.org/1187073014/diff/20001/Source/core/editing/Pos...
File Source/core/editing/PositionWithAffinity.cpp (right):

https://codereview.chromium.org/1187073014/diff/20001/Source/core/editing/Pos...
Source/core/editing/PositionWithAffinity.cpp:28: template class
CORE_EXTERN_TEMPLATE_EXPORT PositionWithAffinityTemplate<Position>;
Use CORE_TEMPLATE_EXPORT here.

Powered by Google App Engine
This is Rietveld 408576698