Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1187053004: Move backgroundColorOf/backgroundColorShouldBe to shadow-dom.js (Closed)

Created:
5 years, 6 months ago by kochi
Modified:
5 years, 6 months ago
Reviewers:
hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Move backgroundColorOf/backgroundColorShouldBe to shadow-dom.js This is a cleanup of moving duplicate backgroundColorOf()/backgroundColorShouldBe() functions in fast/dom/shadow/*.html into shadow-dom.js. No functional change is included. (exception is some tweaks of output text) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -113 lines) Patch
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host1.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host2.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host3.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host5.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/shadow/focus-with-dom-mutation.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-pseudo-class.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 1 chunk +19 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/style-and-shadow-element.html View 2 chunks +0 lines, -19 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187053004/1
5 years, 6 months ago (2015-06-16 08:48:14 UTC) #3
kochi
PTAL
5 years, 6 months ago (2015-06-16 08:58:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 09:54:54 UTC) #6
hayato
lgtm
5 years, 6 months ago (2015-06-19 01:23:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187053004/1
5 years, 6 months ago (2015-06-19 02:04:32 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 03:49:40 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197428

Powered by Google App Engine
This is Rietveld 408576698