chrome/browser/component_updater/test/crx_downloader_unittest.cc - Issue 118703008: Merge 241734 "Added support for multiple urls in the component u..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/test/crx_downloader_unittest.cc

Issue 118703008: Merge 241734 "Added support for multiple urls in the component u..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1750/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/test/component_updater_ping_manager_unittest.cc ('k') | chrome/browser/component_updater/test/update_response_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/test/crx_downloader_unittest.cc

===================================================================

--- chrome/browser/component_updater/test/crx_downloader_unittest.cc (revision 242136)

+++ chrome/browser/component_updater/test/crx_downloader_unittest.cc (working copy)

@@ -104,7 +104,8 @@

}

void CrxDownloaderTest::Quit() {

- quit_closure_.Run();

+ if (!quit_closure_.is_null())

+ quit_closure_.Run();

}

void CrxDownloaderTest::DownloadComplete(

@@ -133,6 +134,18 @@

base::RunLoop().RunUntilIdle();

}

+// Tests that starting a download without a url results in an error.

+TEST_F(CrxDownloaderTest, NoUrl) {

+ std::vector<GURL> urls;

+ crx_downloader_->StartDownload(urls);

+ RunThreadsUntilIdle();

+ EXPECT_EQ(-1, error_);

+ EXPECT_EQ(kExpectedContext, crx_context_);

+ EXPECT_EQ(1, num_calls_);

// Tests that downloading from one url is successful.

TEST_F(CrxDownloaderTest, OneUrl) {

const GURL expected_crx_url =