Add a custome edittext that encapsulates the error message logic

Add a custome edittext that encapsulates the error message logic

For android UI, it is a common pattern to have an edittext that
shows an error message when the cotent is empty. This CL introduces a
custom widget that encapsulates the error message related code.

BUG=NONE
R=newt@chromium.org

Committed: https://crrev.com/1b61d2c59e000fc5cd50b8180b22967c24c4c03a
Cr-Commit-Position: refs/heads/master@{#335161}

[newt (away), 2015-06-17 23:31:07]

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java
(right):

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:17:
* An EditText that shows an alert message when the content is empty.
Let's be consistent with terminology here. Is it an "alert", or an "error"?
TextView calls it "error", but you call it both "alert" and "error" in different
places. Pick one :)

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:21:
String mErrorMessage;
private

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:27:
public EmptyAlertEditText(Context context, AttributeSet attrs, int defStyleAttr)
{
just use 2-arg constructor

[Ian Wen, 2015-06-18 18:12:48]

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java
(right):

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:17:
* An EditText that shows an alert message when the content is empty.
On 2015/06/17 23:31:06, newt wrote:
> Let's be consistent with terminology here. Is it an "alert", or an "error"?
> TextView calls it "error", but you call it both "alert" and "error" in
different
> places. Pick one :)

Done.

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:21:
String mErrorMessage;
On 2015/06/17 23:31:06, newt wrote:
> private

Done.

https://codereview.chromium.org/1187013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:27:
public EmptyAlertEditText(Context context, AttributeSet attrs, int defStyleAttr)
{
On 2015/06/17 23:31:06, newt wrote:
> just use 2-arg constructor

Done.

[newt (away), 2015-06-18 18:20:10]

lgtm

https://codereview.chromium.org/1187013002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java
(right):

https://codereview.chromium.org/1187013002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:23:
public EmptyAlertEditText(Context context, AttributeSet attrs) {
javadoc for public methods. I like to say "Constructor for inflating from XML".
It's obvious that it's a constructor, but it's not immediately obvious that this
is the constructor that's used when inflating a layout.

[Ian Wen, 2015-06-18 22:29:22]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-06-18 22:29:23]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1187013002/#ps60001
(title: "nit")

[Ian Wen, 2015-06-18 22:29:27]

https://codereview.chromium.org/1187013002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java
(right):

https://codereview.chromium.org/1187013002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java:23:
public EmptyAlertEditText(Context context, AttributeSet attrs) {
On 2015/06/18 18:20:10, newt wrote:
> javadoc for public methods. I like to say "Constructor for inflating from
XML".
> It's obvious that it's a constructor, but it's not immediately obvious that
this
> is the constructor that's used when inflating a layout.

Done.

[commit-bot: I haz the power, 2015-06-18 22:31:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187013002/60001

[commit-bot: I haz the power, 2015-06-18 23:39:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-18 23:40:22]

Patchset 4 (id:??) landed as
https://crrev.com/1b61d2c59e000fc5cd50b8180b22967c24c4c03a
Cr-Commit-Position: refs/heads/master@{#335161}