Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1187003002: Retires scoped_ptr for BoundsAnimator of message_list_view. (Closed)

Created:
5 years, 6 months ago by Jun Mukai
Modified:
5 years, 3 months ago
Reviewers:
yoshiki, dewittj
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retires scoped_ptr for BoundsAnimator of message_list_view. It's now quite complicated for the animation status in the message_list_view. I think it's a bit better to get rid of scoped_ptr and hold BoundsAnimator as a normal field. BUG=None R=dewittj@chromium.org, yoshiki@chromium.org TEST=None Committed: https://crrev.com/e0096ef8707579fd6507e3e228df0c0c3afc8df8 Cr-Commit-Position: refs/heads/master@{#346413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M ui/message_center/views/message_list_view.h View 3 chunks +2 lines, -5 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 10 chunks +14 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yoshiki
Thank you for catching my patch and making it better way. I confirms it also ...
5 years, 6 months ago (2015-06-16 05:58:33 UTC) #1
Jun Mukai
dewittj, please also take a look.
5 years, 6 months ago (2015-06-16 16:31:07 UTC) #2
dewittj
lgtm
5 years, 6 months ago (2015-06-22 17:10:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187003002/1
5 years, 6 months ago (2015-06-22 17:18:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/70349)
5 years, 6 months ago (2015-06-22 18:20:02 UTC) #7
dewittj
ping
5 years, 3 months ago (2015-08-31 16:01:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1187003002/1
5 years, 3 months ago (2015-08-31 16:42:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 17:50:31 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 17:51:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0096ef8707579fd6507e3e228df0c0c3afc8df8
Cr-Commit-Position: refs/heads/master@{#346413}

Powered by Google App Engine
This is Rietveld 408576698