Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1186973005: [turbofan] Remove another premature optimization from ControlReducer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove another premature optimization from ControlReducer. We never hit the phi case for DecideCondition in practice, since a more general optimization is already performed by typing and constant propagation. R=jarin@chromium.org,mstarzinger@chromium.org Committed: https://crrev.com/a3106d228ecaf8f307a0c6fc070d163acc9d0b86 Cr-Commit-Position: refs/heads/master@{#29102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -108 lines) Patch
M src/compiler/control-reducer.cc View 2 chunks +1 line, -14 lines 0 comments Download
M test/unittests/compiler/control-reducer-unittest.cc View 2 chunks +2 lines, -94 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-18 06:45:34 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, this code is completely dead in practice. Please take a ...
5 years, 6 months ago (2015-06-18 06:46:21 UTC) #2
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-18 06:48:10 UTC) #3
Jarin
lgtm
5 years, 6 months ago (2015-06-18 06:48:53 UTC) #4
Benedikt Meurer
For the record: To verify that the optimization is completely useless, I added a CHECK(result==kUnknown); ...
5 years, 6 months ago (2015-06-18 06:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186973005/1
5 years, 6 months ago (2015-06-18 07:00:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 07:13:41 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 07:13:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3106d228ecaf8f307a0c6fc070d163acc9d0b86
Cr-Commit-Position: refs/heads/master@{#29102}

Powered by Google App Engine
This is Rietveld 408576698