Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issue 1186943003: Revert of Add support for the audio-output-device switching IPC mechanism to the renderer lower... (Closed)

Created:
5 years, 6 months ago by Jamie Madill
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for the audio-output-device switching IPC mechanism to the renderer lower layers (media… (patchset #10 id:180001 of https://codereview.chromium.org/1184473002/) Reason for revert: Breaking the GPU.FYI debug builders. Sample output: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -fuse-ld=gold -B/b/build/slave/GPU_Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -m64 -Wl,--detect-odr-violations -Wl,--icf=safe -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o audio_unittests -Wl,--start-group obj/media/base/audio_unittests.run_all_unittests.o obj/media/audio/audio_unittests.audio_input_controller_unittest.o obj/media/audio/audio_unittests.audio_input_unittest.o obj/media/audio/audio_unittests.audio_manager_factory_unittest.o obj/media/audio/audio_unittests.audio_manager_unittest.o obj/media/audio/audio_unittests.audio_output_controller_unittest.o obj/media/audio/audio_unittests.audio_output_device_unittest.o obj/media/audio/audio_unittests.audio_output_proxy_unittest.o obj/media/audio/audio_unittests.audio_parameters_unittest.o obj/media/audio/audio_unittests.audio_power_monitor_unittest.o obj/media/audio/audio_unittests.fake_audio_worker_unittest.o obj/media/audio/audio_unittests.simple_sources_unittest.o obj/media/audio/audio_unittests.virtual_audio_input_stream_unittest.o obj/media/audio/audio_unittests.virtual_audio_output_stream_unittest.o obj/media/audio/audio_unittests.audio_input_volume_unittest.o obj/media/audio/alsa/audio_unittests.alsa_output_unittest.o obj/media/audio/audio_unittests.audio_low_latency_input_output_unittest.o obj/media/libmedia_test_support.a obj/base/libtest_support_base.a obj/testing/libgmock.a obj/testing/libgtest.a obj/ui/gfx/libgfx_test_support.a obj/base/libbase_static.a obj/third_party/libxml/libxml2.a obj/third_party/zlib/libchrome_zlib.a obj/third_party/zlib/libzlib_x86_simd.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a -Wl,--end-group lib/libicuuc.so lib/libskia.so lib/libbase.so lib/libshared_memory_support.so lib/libmedia.so lib/libbase_i18n.so -lasound -ldl -lrt -lm -lfontconfig ../../media/audio/audio_output_device_unittest.cc:216: error: undefined reference to 'GURL::GURL(std::string const&)' ../../media/audio/audio_output_device_unittest.cc:235: error: undefined reference to 'GURL::~GURL()' ../../testing/gmock/include/gmock/gmock-matchers.h:3711: error: undefined reference to 'GURL::GURL(GURL const&)' ../../testing/gmock/include/gmock/gmock-matchers.h:3711: error: undefined reference to 'GURL::~GURL()' ../../testing/gtest/include/gtest/gtest-printers.h:249: error: undefined reference to 'operator<<(std::ostream&, GURL const&)' ../../testing/gmock/include/gmock/gmock-matchers.h:895: error: undefined reference to 'GURL::GURL(GURL const&)' ../../testing/gmock/include/gmock/gmock-matchers.h:905: error: undefined reference to 'GURL::GURL(GURL const&)' ../../testing/gmock/include/gmock/gmock-matchers.h:903: error: undefined reference to 'GURL::~GURL()' ../../testing/gmock/include/gmock/gmock-matchers.h:204: error: undefined reference to 'GURL::operator==(GURL const&) const' ../../testing/gmock/include/gmock/gmock-matchers.h:893: error: undefined reference to 'GURL::~GURL()' clang: error: linker command failed with exit code 1 (use -v to see invocation) BUG=438023 Original issue's description: > Add support for the audio-output-device switching IPC mechanism to the renderer lower layers (media::AudioOutputDevice, content::AudioMessageFilter and related classes). > > The idea is to provide support for the Audio Output Devices API (http://w3c.github.io/mediacapture-output/) > > BUG=438023 > > Committed: https://crrev.com/8c7fc2c8746c9cb294a5906572f23fbfc34726b3 > Cr-Commit-Position: refs/heads/master@{#334451} TBR=tommi@chromium.org,bbudge@chromium.org,dalecurtis@chromium.org,miu@chromium.org,mkwst@chromium.org,guidou@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=438023 Committed: https://crrev.com/d15b32c89d9d193e29044a0e96cd062b625c0d54 Cr-Commit-Position: refs/heads/master@{#334462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -354 lines) Patch
M content/renderer/media/audio_message_filter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 5 chunks +0 lines, -34 lines 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 5 chunks +0 lines, -28 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/audio_output_device.h View 5 chunks +0 lines, -15 lines 0 comments Download
M media/audio/audio_output_device.cc View 6 chunks +1 line, -64 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 6 chunks +0 lines, -45 lines 0 comments Download
M media/audio/audio_output_ipc.h View 2 chunks +0 lines, -9 lines 0 comments Download
M media/audio/audio_output_stream_sink.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/audio/audio_output_stream_sink.cc View 1 chunk +1 line, -8 lines 0 comments Download
M media/audio/clockless_audio_sink.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/audio/clockless_audio_sink.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M media/audio/null_audio_sink.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/null_audio_sink.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M media/base/audio_renderer_mixer.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/audio_renderer_mixer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M media/base/audio_renderer_mixer_input.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/audio_renderer_mixer_input.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M media/base/audio_renderer_sink.h View 2 chunks +0 lines, -26 lines 0 comments Download
M media/base/fake_audio_renderer_sink.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/fake_audio_renderer_sink.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M media/base/mock_audio_renderer_sink.h View 2 chunks +0 lines, -8 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie Madill
Created Revert of Add support for the audio-output-device switching IPC mechanism to the renderer lower ...
5 years, 6 months ago (2015-06-15 21:27:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186943003/1
5 years, 6 months ago (2015-06-15 21:29:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 21:30:48 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 21:31:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d15b32c89d9d193e29044a0e96cd062b625c0d54
Cr-Commit-Position: refs/heads/master@{#334462}

Powered by Google App Engine
This is Rietveld 408576698