Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1894)

Issue 1186903005: Add option to compute average scavenge speed w.r.t survived objects. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add option to compute average scavenge speed w.r.t survived objects. Use it in detection of low young generation allocation rate. BUG=501314 LOG=NO TBR=hpayer@chromium.org Committed: https://crrev.com/b62a7a833b80e7408a42b3a7fe93672097d5aaa7 Cr-Commit-Position: refs/heads/master@{#29094}

Patch Set 1 #

Patch Set 2 : Remove debug print #

Patch Set 3 : bump limit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M src/heap/gc-tracer.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
PTAL. This make scavenge speed more stable and fixes regression in Octane where low survival ...
5 years, 6 months ago (2015-06-17 14:47:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186903005/40001
5 years, 6 months ago (2015-06-17 15:00:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 15:59:25 UTC) #6
ulan
On 2015/06/17 15:59:25, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-17 16:01:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186903005/40001
5 years, 6 months ago (2015-06-17 16:01:32 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-17 16:03:11 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 16:03:31 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b62a7a833b80e7408a42b3a7fe93672097d5aaa7
Cr-Commit-Position: refs/heads/master@{#29094}

Powered by Google App Engine
This is Rietveld 408576698